Rename ...using_command fish function, set $cmd in local scope
#377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__fish_* should not be used by external projects. set -l cmd in case user has a global or universal `cmd` defined.
Contributor
|
@swift-ci please test |
Contributor
Author
|
There was a test failure; I believe I force-pushed the correction. |
Contributor
|
@swift-ci please test |
And worse. Oops!
Contributor
Author
|
Okay, I'm finally running |
Contributor
|
@swift-ci please test |
Member
|
This is great, thanks @floam! 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two minor changes for FishCompletionsGenerator.swift.
The first is related to the name of the fish function created that's used to determine whether to show completions or not, depending on the commandline entered thus far. Functions beginning with
__fishreally ought only be things internal to fish that are included with the shell. So prefix the function_swiftinstead.Secondly,
set --local cmdinstead ofset cmd- this ensures running the function does not accidentally clobber a global or universal variable.