Merged
Conversation
rgoldberg
force-pushed
the
improve-zsh-completions
branch
2 times, most recently
from
bc53deb to
6fa5310
Compare
…subcommand arguments, which prevents functions from being unnecessarily called multiple times. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Call the main completion function iff the function is being called, which avoids an unnecessary call, but calls when necessary to avoid requiring a second tab when the script is first loaded. Otherwise, calls compdef for the function & command, which allows the script to be sourced instead of autoloaded. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
improve-zsh-completions
branch
from
6fa5310 to
77427e4
Compare
natecook1000
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 2 issues in zsh completions. See the commit messages for the respective issues & fixes.
Checklist