Fix build failures for Swift 5#874
Conversation
refs apple#803 `swift package resolve` in Swift 5.8.x: ``` Computing version for https://github.com/apple/swift-argument-parser.git error: Invalid manifest (compiled with: ["/usr/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.HCuAi3/vfs.yaml", "-L", "/usr/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/usr/lib/swift/pm/ManifestAPI", "-swift-version", "5", "-I", "/usr/lib/swift/pm/ManifestAPI", "-package-description-version", "5.8.0", "/Package@swift-5.8.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/tmp/TemporaryDirectory.RLkqp3/swift-argument-parser-manifest"]) /Package@swift-5.8.swift:149:9: error: type 'Target.TargetType' has no member 'macro' case .macro, .plugin, .system, .binary: ~^~~~~ in https://github.com/apple/swift-argument-parser.git ```
|
My PR #855 removes the usage of Given that my PR improves functionality & that many changes in this PR conflict with my PR, I think it makes sense to try to merge mine first, then rebase this PR so it fixes only the remaining Swift 5 build issues. |
|
@rgoldberg I'm planning to land this PR first, so that we can have one more patch release with the current supported list of Swift versions. In the next minor release I'd like to raise the minimum to Swift 6 to cut down on the level of testing/support. |
|
@natecook1000 Would't bumping the minimum Swift version require a new major version for semantic versioning? Does SAP not use semantic versioning? |
|
Swift Package Manager resolves packages with an understanding of which Swift versions are supported, so for Swift versions prior to 6.0, they'll just see 1.7.1 as the last available version. |
fix #870
This fixes build failures caused by:
AsyncParsableCommandvia async/await #855 first, unnecessary cec9c2f, so needs drop this.MemberImportVisibility#803Checklist