Improve fish completions#911
Merged
Merged
Conversation
rgoldberg
force-pushed
the
improve-fish-completions
branch
from
4a02915 to
fc6756c
Compare
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…ipts. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…ipts more concise. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…ouldOfferCompletionsForPositionalFunction. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
improve-fish-completions
branch
from
561d0aa to
5114da9
Compare
natecook1000
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple improvements for fish completions.
I have more improvements pending for a subsequent PR, but I haven't looked at them in a while, so need to test those more, while these are ready to go.
I figured I should submit these simple improvements to merge them without waiting for the more complex improvements.
Checklist