Remove incorrect lifetime annotations on methods of Escapable types#45
Merged
DougGregor merged 2 commits intoapple:mainfrom Jan 6, 2026
Merged
Conversation
DougGregor
force-pushed
the
remove-incorrect-lifetime-annotations
branch
from
b8d7bfb to
9b78741
Compare
One cannot provide a lifetime annotation for a method of an escapable type, because they don't have lifetimes. Older compilers didn't diagnose this, but newer ones produce an error. Remove all of these incorrect lifetime annotations.
DougGregor
force-pushed
the
remove-incorrect-lifetime-annotations
branch
from
9b78741 to
a44e419
Compare
meg-gupta
reviewed
Jan 6, 2026
| @inlinable | ||
| #if compiler(<6.3) | ||
| @_lifetime(copy self) | ||
| #endif |
There was a problem hiding this comment.
Shouldn't this be @_lifetime(self: copy self) ? I think that works for swift 6.2+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One cannot provide a lifetime annotation for a method of an escapable type, because they don't have lifetimes. Older compilers didn't diagnose this, but newer ones produce an error. Remove all of these incorrect lifetime annotations.
Checklist
Scripts/format.shto correctly format my change