Require VerifierPolicy not have isolated conformance #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation While conceptually it is possible for verifier policies to have isolated conformance, in practice the way PolicyBuilder is implemented makes that nearly impossible. Given that the utility of an isolated VerifierPolicy is very limited, let's just disallow it. Modifications Require VerifierPolicy to have a SendableMetatype Result Easier to build correct compositions over PolicyBuilder
Lukasa
force-pushed
the
cb-sendable-metatype
branch
from
c4a2458 to
75d62cb
Compare
gjcairo
approved these changes
Jul 25, 2025
Contributor
Author
|
Merging over the API breakage checker, which is expected and wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While conceptually it is possible for verifier policies to have isolated conformance, in practice the way PolicyBuilder is implemented makes that nearly impossible. Given that the utility of an isolated VerifierPolicy is very limited, let's just disallow it.
Modifications
Require VerifierPolicy to have a SendableMetatype
Result
Easier to build correct compositions over PolicyBuilder