Drop Swift 5.10 #283
Merged
Drop Swift 5.10 #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 5.10 is no longer supported. We should raise the minimum Swift tools version to 6.0, fix consequent build warnings/errors, and remove 5.10 CI jobs. Modifications: - Raised the Swift tools version to 6.0 in both the main swift-certificates package and the Benchmark package. - Removed the now redundant `StrictConcurrency=complete` flag in `swift-certificates`' `Package.swift`. - Removed 5.10 CI job arguments. - Removed 5.10 benchmark thresholds. - Added an explicit type annotation to the `package-benchmark` setup closure to address a build error. - Updated `VerifierBenchmark` to use newer, non-deprecated `RFC5280Policy` initializers (as a result of apple#276). Result: Code reflects our support window.
Contributor
|
This looks like there's some deprecation warnings that are bubbling up as errors. |
Lukasa
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 5.10 is no longer supported. We should raise the minimum Swift tools version to 6.0, fix consequent build warnings/errors, and remove 5.10 CI jobs.
Modifications:
swift-certificatespackage and the Benchmark package.StrictConcurrency=completeflag inswift-certificates'Package.swift.package-benchmarksetup closure to address a build error.VerifierBenchmarkto use newer, non-deprecatedRFC5280Policyinitializers (as a result of Update RFC5280Policy and OCSPVerifierPolicy initializers #276).Tests/X509Tests/PEMTests.swiftto no longer use a deprecatedStringinitializer.Result:
Code reflects our support window.