This repository was archived by the owner on Mar 28, 2020. It is now read-only.
[APINotes] Honor Swift 4 API notes in Swift 3 mode. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
commented
Sep 7, 2017
| Results[Selected].first > Results[i].first) { | ||
| Selected = i; | ||
| } | ||
| break; |
There was a problem hiding this comment.
Oops. This break is wrong. Either I need a test to catch this, or I should guarantee that the list is always sorted.
More generally, change the meaning of the SwiftVersions section to be "this version or earlier" rather than "exactly this version". This keeps us from having to duplicate information for builds of Swift that support more than two possible versions (e.g. 3, 4, and 5).
No functionality change.
jrose-apple
force-pushed
the
apinotes-less-than-or-equal
branch
from
aa786ad to
202145d
Compare
This was referenced Sep 9, 2017
DougGregor
approved these changes
Sep 14, 2017
| llvm::function_ref<void(raw_ostream &out, | ||
| const typename MakeDependent<T>::Type& info)> | ||
| emitInfo) { | ||
| std::sort(infoArray.begin(), infoArray.end(), |
There was a problem hiding this comment.
It's not necessarily POD, is it?
There was a problem hiding this comment.
Well. Maybe not by the language definition., but it'd work. std::sort() is not exactly a small thing to instantiate.
jrose-apple
added a commit
to jrose-apple/swift-clang
that referenced
this pull request
Sep 15, 2017
…qual [APINotes] Honor Swift 4 API notes in Swift 3 mode. (cherry picked from commit 772e04d)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More generally, change the meaning of the SwiftVersions section to be "this version or earlier" rather than "exactly this version". This keeps us from having to duplicate information for builds of Swift that support more than two possible versions (e.g. 3, 4, and 5).