Skip to content

ContainerRegistry: Fix a few requests which were not using swift-http-types error codes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

ContainerRegistry: Fix a few requests which were not using swift-http-types error codes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/ContainerRegistry/Blobs.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public extension RegistryClient {
do {
let _ = try await executeRequestThrowing(
.head(registryURLForPath("/v2/\(repository)/blobs/\(digest)")),
decodingErrors: [404]
decodingErrors: [.notFound]
)
return true
} catch HTTPClientError.unexpectedStatusCode(status: .notFound, _, _) { return false }
Expand All @@ -83,7 +83,7 @@ public extension RegistryClient {

return try await executeRequestThrowing(
.get(registryURLForPath("/v2/\(repository)/blobs/\(digest)"), accepting: ["application/octet-stream"]),
decodingErrors: [404]
decodingErrors: [.notFound]
)
.data
}
Expand All @@ -106,7 +106,7 @@ public extension RegistryClient {

return try await executeRequestThrowing(
.get(registryURLForPath("/v2/\(repository)/blobs/\(digest)"), accepting: ["application/octet-stream"]),
decodingErrors: [404]
decodingErrors: [.notFound]
)
.data
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/ContainerRegistry/Tags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public extension RegistryClient {
precondition(repository.count > 0, "repository must not be an empty string")
return try await executeRequestThrowing(
.get(registryURLForPath("/v2/\(repository)/tags/list")),
decodingErrors: [404]
decodingErrors: [.notFound]
)
.data
}
Expand Down