Skip to content

Conversation

@ktoso
Copy link
Member

@ktoso ktoso commented Jul 3, 2020

Motivation:

Since we noticed it again in the sample app

        system.shutdown(queue: .global(), afterShutdownCompleted: { error in
            receptacle.offerOnce(error)
        })

Modifications:

  • we now have a callback on shutdown.
  • the wait() can throw, which makes sense to get the errors out if we dont have the callback

Result:

resolves #230

@ktoso
Copy link
Member Author

ktoso commented Jul 3, 2020

Timing sensitive Test Case 'DowningClusteredTests.test_many_nonLeaders_shouldPropagateToOtherNodes' failed (72.414 seconds) still 🤔

@ktoso
Copy link
Member Author

ktoso commented Jul 3, 2020

Ticket #712

@ktoso ktoso merged commit f79a523 into apple:master Jul 3, 2020
@ktoso ktoso deleted the wip-shutdown-callback branch July 3, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shutdown to gain a callback version

1 participant