exact nio ssl version for compat with specific project which requires it #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
approved these changes
Aug 1, 2020
Member
Author
|
I dont think we can merge this though hm... Yet another version uses 2.8 etc... we need to figure out a real answer hm |
Member
Author
|
Ok the more proper "fix" here is that we should require 2.8 and then it's up to others to bump dependencies. |
ktoso
commented
Aug 3, 2020
| var dependencies: [Package.Dependency] = [ | ||
| .package(url: "https://github.com/apple/swift-nio.git", from: "2.12.0"), | ||
| .package(url: "https://github.com/apple/swift-nio-extras.git", from: "1.2.0"), | ||
| .package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.2.0"), |
Member
Author
There was a problem hiding this comment.
ok now good to merge, on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because: apple/swift-nio-ssl#236
and a specific project pinning the NIO version, we have to also pin and add the try.
It is impossible for us to support both versions because the change apple/swift-nio-ssl#236 causes either a deprecation warning, or an extrra try where there should not be one warning -- and we build with warnings as errors, so we can't build in either "compat with everything" style...
:-(
Not sure for a real solution other than the other project updating to 2.8+