Make withSpan set span status to .error if operation closure throws
#201
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation:** Span status is relied upon by application developers to quickly discover spans that have thrown a exception. **Modifications:** Ensure that all tracer protocols set the span status to `.error` when the underlying operation closure throws during execution. **Result:** When an error is thrown from a `withSpan` operation closure the underlying span has an `.error` span status code on return.
ktoso
approved these changes
Dec 15, 2025
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Hmm I can’t think of a reason why we wouldn’t want to set the status to error in the withSpan APIs as the entire span is failed then.
FYI @simonjbeaumont @slashmo for otel interaction, however I believe this is compatible and valid within otel rules as well.
We should not have record error cause a status change but I agree with WithSpan APIs should.
Contributor
Author
|
Yeah I purposefully only did it in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Span status is relied upon by application developers to quickly discover spans that have thrown a exception.
Modifications:
Ensure that all tracer protocols set the span status to
.errorwhen the underlying operation closure throws during execution.Result:
When an error is thrown from a
withSpanoperation closure the underlying span has an.errorspan status code on return.Closes: #200