Avoid using CFilePointer typealias in default logger#433
Merged
kukushechkin merged 3 commits intoapple:mainfrom Mar 27, 2026
Merged
Avoid using CFilePointer typealias in default logger#433kukushechkin merged 3 commits intoapple:mainfrom
kukushechkin merged 3 commits intoapple:mainfrom
Conversation
ktoso
approved these changes
Mar 27, 2026
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
lgtm, just needs formatting fix
kukushechkin
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the default log handler to avoid typing out what the C file pointer looks like on different platforms.
This fixes #374 - as we do not make any assumptions at compile time about what
FILE*is imported as in Swift.