Add tests for SwiftLogNoOpLogHandler#449
Merged
kukushechkin merged 2 commits intoapple:mainfrom Apr 27, 2026
Merged
Conversation
Add tests for SwiftLogNoOpLogHandler ### Motivation: `SwiftLogNoOpLogHandler` is a public type with no dedicated test coverage. ### Modifications: * Add tests for both initialisers, `logLevel`, `metadata`, the metadata subscript, `log(event:)`, and end-to-end usage via `Logger`. ### Result: `SwiftLogNoOpLogHandler` has test coverage on par with other handlers.
Contributor
|
@crleonard thank you for the contribution! I understand the motivation to fill the coverage gap, but I think the main value in testing |
Contributor
Author
|
@kukushechkin thanks for the quick review, updated the test names. |
kukushechkin
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for SwiftLogNoOpLogHandler
Motivation:
SwiftLogNoOpLogHandleris a public type with no dedicated test coverage.Modifications:
logLevel,metadata, the metadata subscript,log(event:), and end-to-end usage viaLogger.Result:
SwiftLogNoOpLogHandlerhas test coverage on par with other handlers.Coverage from 89% over all tests, to 90%.