Add diagnostics for bit field ranges #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
force-pushed
the
bitrange-diagnostics
branch
from
4c22222 to
26a0e6a
Compare
Validates the bit ranges passed to bit field macros do not overlap nor do they extend past the register bounds. In either case, diagnostics are emitted indicating the offending attribute and offending range[s]. Given the example bit field: ```swift @bitfield(bits: 0..<24, 8..<32, 16..<48, 36..<44) var field: Field ``` The ranges visually look like: ``` 0 8 16 24 32 36 44 48 ╎ ╎ ╎ ╎ ╎ ╎ ╎ ╎ •───────────────────────◦ ╎ ╎ ╎ ╎ ╎ •───────────────────────◦ ╎ ╎ ╎ ╎ ╎ •───────────────────────────────◦ ╎ ╎ ╎ ╎ ╎ •───────◦ ╎ ╎ ╎ ╎ ╎ ╎ ╎ ╎ ╎ 0 8 16 24 32 36 44 48 ``` The following diagnostics will be emitted: ``` <location> error: overlapping bit ranges in '@bitfield(bits: 0..<24, 8..<40, 16..<48, 36..<44)' @bitfield(bits: 0..<24, 8..<40, 16..<48, 36..<44) ^~~~~~~~ <location> note: bit range '0..<24' overlaps bit ranges '8..<32' and '16..<48' over subrange '8..<24' @bitfield(bits: 0..<24, 8..<40, 16..<48, 36..<44) ^~~~~~ <location> note: bit range '8..<32' overlaps bit ranges '0..<24' and '16..<48' @bitfield(bits: 0..<24, 8..<32, 16..<48, 36..<44) ^~~~~~ <location> note: bit range '16..<48' overlaps bit ranges '0..<24', '8..<32', and '36..<44' over anges '16..<32' and '36..<44' @bitfield(bits: 0..<24, 8..<40, 16..<48, 36..<44) ^~~~~~~ <location> note: bit range '36..<44' overlaps bit range '16..<48' @bitfield(bits: 0..<24, 8..<40, 16..<48, 36..<44) ^~~~~~~ ```
rauhul
force-pushed
the
bitrange-diagnostics
branch
from
26a0e6a to
c48bb6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates the bit ranges passed to bit field macros do not overlap nor
do they extend past the register bounds. In either case, diagnostics are
emitted indicating the offending attribute and offending range[s].
Given the example bit field:
The ranges visually look like:
The following diagnostics will be emitted: