workaround SR-11125: @_implementationOnly import CNIOBoringSSL #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Jul 17, 2019
| /// In general, however, this function should be avoided in favour of one of the convenience | ||
| /// initializers, which ensure that the lifetime of the `X509` object is better-managed. | ||
| static public func fromUnsafePointer(takingOwnership pointer: UnsafeMutablePointer<X509>) -> NIOSSLCertificate { | ||
| static func fromUnsafePointer(takingOwnership pointer: UnsafeMutablePointer<X509>) -> NIOSSLCertificate { |
There was a problem hiding this comment.
This is technically a breaking API change. Do we want to ship a 3.0 here? Or do we think this can be made an exception?
There was a problem hiding this comment.
Yup, my vote goes for exception. There was never a legal way to obtain an UnsafeMutablePointer<X509> (with the right X509...).
Motivation: If we don't import CNIOBoringSSL @_implementationOnly, then some details of libssl's C structs might leak into NIOSSL's ABI which might lead to clashes further down the line. Modification: - make all CNIOBoringSSL(Shims) imports @_implementationOnly - remove all concrete libssl types from instance variables Result: - fixes apple#116 - works around SR-11125
weissi
force-pushed
the
jw-workaround-SR-11125
branch
from
aae6472 to
049619d
Compare
Lukasa
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If we don't import CNIOBoringSSL @_implementationOnly, then some details
of libssl's C structs might leak into NIOSSL's ABI which might lead to
clashes further down the line.
Modification:
Result: