Extract macOS benchmarks into a separate reusable workflow #3461
+162
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Dec 10, 2025
rnro
approved these changes
Dec 11, 2025
kukushechkin
deleted the
extract-macos-benchmarks-into-a-separate-workflow
branch
kukushechkin
added a commit
to apple/swift-log
that referenced
this pull request
Dec 11, 2025
Depends on apple/swift-nio#3461, which is not yet merged ### Motivation: `swift-nio` now has 2 separate workflows for running benchmarks on Linux and macOS to remove unnecessary noise of skipped macOS benchmarks, see [`swift-nio` PR](apple/swift-nio#3461) for details. ### Modifications: Split Linux and macOS benchmarks into different jobs. ### Result: Linux and macOS benchmarks are running as different jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract macOS benchmarks into a separate reusable workflow to completely remove them if they are not meant to be used.
Motivation:
macOS Benchmarks is an opt-in workflow. If no macOS versions selected to run benchmarks on, there is now a skipped matrix jobs, creating unnecessary visual and cognitive noise during workflow results analysis:
Modifications:
macOS benchmarks workflow is extracted into a separate reusable workflow.
Result:
macos_benchmarks.ymlworkflow should be used.swift-log?) need to adopt the new reusable workflow.Test runs: