Fix potential crash in withDeadline
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Jun 5, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Thanks! This is missing a license header, it needs the formatter run, and the test fails on main which is worth looking at.
FranzBusch
force-pushed
the
fb-fix-timeout
branch
from
12f0aaf to
7072ec0
Compare
Member
Author
|
@Lukasa Thanks sorry for missing that |
FranzBusch
force-pushed
the
fb-fix-timeout
branch
from
7072ec0 to
0040f8d
Compare
FranzBusch
force-pushed
the
fb-fix-timeout
branch
from
0040f8d to
b15a96c
Compare
Lukasa
approved these changes
Jun 5, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Very nice, thanks @FranzBusch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4