Change extendingOrTruncating to truncatingIfNeeded
#663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 4 prerelease (until Xcode 9 beta 4 at least) has been using the former name for the truncating initializer and just recently switched to the latter term. Unlike PR#662, this also updates MathUtils.swift so that we preserve compatibility with Swift 3. It also omits any changes to the xcodeproj files.
thomasvl
reviewed
Sep 19, 2017
| #if !swift(>=4.0) | ||
| // | ||
| // Swift 3 called this initializer "truncatingBitPattern"; | ||
| // Swift 4 (prerelease) changed this initializer to |
Collaborator
There was a problem hiding this comment.
Maybe drop the "(prerelease)" part since I doubt it is changing again?
thomasvl
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 4 prerelease (until Xcode 9 beta 4 at least) has been using the
former name for the truncating initializer and just recently switched
to the latter term.
Unlike PR#662, this also updates MathUtils.swift so that we
preserve compatibility with Swift 3. It also omits any changes
to the xcodeproj files.
Tested using command-line tools with Xcode 8.1, 8.2., 8.3, and 9.0 GM Seed (9A235).