Conversation
- Replace file.IsDir check with direct os.MkdirAll to avoid fatal error when config directory path does not exist - Remove -H flag from adduser so the home directory is created for the codegpt user in Docker Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a Docker container issue (GitHub issue #256) where the codegpt user's home directory was not created in the container, causing fatal errors when the application tried to access its config directory at /home/codegpt/.config/codegpt.
Changes:
- Removed the
-Hflag fromadduserin the Dockerfile so the home directory is created for thecodegptuser - Simplified config folder creation in
cmd/cmd.goby replacing thefile.IsDircheck + conditionalos.MkdirAllwith a directos.MkdirAllcall, which handles non-existent parent paths gracefully
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker/Dockerfile | Removed -H flag from adduser to ensure /home/codegpt is created |
| cmd/cmd.go | Replaced file.IsDir check with direct os.MkdirAll for config folder creation to avoid fatal error when path doesn't exist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if err := os.MkdirAll(configFolder, os.ModePerm); err != nil { | ||
| log.Fatalf("failed to create config folder %s: %v", configFolder, err) |
There was a problem hiding this comment.
The same file.IsDir pattern that caused the original bug (issue #256) still exists in the prompt folder handling below (lines 139-142, 162-165, and 177-180). For example, in the default case at line 177, if $HOME/.config/codegpt/prompt doesn't exist, file.IsDir will return an error from os.Stat, and the code will log.Fatalf before os.MkdirAll has a chance to create it. Consider applying the same os.MkdirAll fix to all three prompt folder cases as well.
fix #256