Skip to content

chore(go): update to go 1.14 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appleboy merged 2 commits into from
Feb 27, 2020
Merged

chore(go): update to go 1.14 #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce1b273
chore(go): update to go 1.14
appleboy Feb 27, 2020
86cdcd5
fix testing
appleboy Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ platform:
steps:
- name: vet
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make vet
volumes:
Expand All @@ -18,7 +18,7 @@ steps:

- name: lint
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make lint
volumes:
Expand All @@ -27,7 +27,7 @@ steps:

- name: misspell
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make misspell-check
volumes:
Expand All @@ -36,7 +36,7 @@ steps:

- name: embedmd
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make embedmd
volumes:
Expand All @@ -45,7 +45,7 @@ steps:

- name: test
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make test
environment:
Expand Down Expand Up @@ -83,7 +83,7 @@ platform:
steps:
- name: build-push
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/amd64/gorush
environment:
Expand All @@ -95,7 +95,7 @@ steps:

- name: build-tag
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.version=${DRONE_TAG##v} -X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/amd64/gorush
environment:
Expand All @@ -106,7 +106,7 @@ steps:

- name: executable
pull: always
image: golang:1.13
image: golang:1.14
commands:
- ./release/linux/amd64/gorush --help

Expand Down Expand Up @@ -162,7 +162,7 @@ platform:
steps:
- name: build-push
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/arm64/gorush
environment:
Expand All @@ -174,7 +174,7 @@ steps:

- name: build-tag
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.version=${DRONE_TAG##v} -X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/arm64/gorush
environment:
Expand All @@ -185,7 +185,7 @@ steps:

- name: executable
pull: always
image: golang:1.13
image: golang:1.14
commands:
- ./release/linux/arm64/gorush --help

Expand Down Expand Up @@ -241,7 +241,7 @@ platform:
steps:
- name: build-push
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/arm/gorush
environment:
Expand All @@ -253,7 +253,7 @@ steps:

- name: build-tag
pull: always
image: golang:1.13
image: golang:1.14
commands:
- go build -v -ldflags '-X main.version=${DRONE_TAG##v} -X main.build=${DRONE_BUILD_NUMBER}' -a -o release/linux/arm/gorush
environment:
Expand All @@ -264,7 +264,7 @@ steps:

- name: executable
pull: always
image: golang:1.13
image: golang:1.14
commands:
- ./release/linux/arm/gorush --help

Expand Down Expand Up @@ -320,7 +320,7 @@ platform:
steps:
- name: build-all-binary
pull: always
image: golang:1.13
image: golang:1.14
commands:
- make release
when:
Expand Down
2 changes: 1 addition & 1 deletion gorush/notification_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func TestSetProxyURL(t *testing.T) {

err := SetProxy("87.236.233.92:8080")
assert.Error(t, err)
assert.Equal(t, "parse 87.236.233.92:8080: invalid URI for request", err.Error())
assert.Equal(t, "parse \"87.236.233.92:8080\": invalid URI for request", err.Error())

err = SetProxy("a.html")
assert.Error(t, err)
Expand Down
20 changes: 10 additions & 10 deletions pipeline.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
steps: [
{
name: 'vet',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'make vet',
Expand All @@ -23,7 +23,7 @@
},
{
name: 'lint',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'make lint',
Expand All @@ -37,7 +37,7 @@
},
{
name: 'misspell',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'make misspell-check',
Expand All @@ -51,7 +51,7 @@
},
{
name: 'embedmd',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'make embedmd',
Expand All @@ -65,7 +65,7 @@
},
{
name: 'test',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
environment: {
ANDROID_API_KEY: { 'from_secret': 'android_api_key' },
Expand Down Expand Up @@ -114,7 +114,7 @@
steps: [
{
name: 'build-push',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
environment: {
CGO_ENABLED: '0',
Expand All @@ -130,7 +130,7 @@
},
// {
// name: 'build-push-lambda',
// image: 'golang:1.13',
// image: 'golang:1.14',
// pull: 'always',
// environment: {
// CGO_ENABLED: '0',
Expand All @@ -146,7 +146,7 @@
// },
{
name: 'build-tag',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
environment: {
CGO_ENABLED: '0',
Expand All @@ -160,7 +160,7 @@
},
{
name: 'executable',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'./release/' + os + '/' + arch + '/' + name + ' --help',
Expand Down Expand Up @@ -225,7 +225,7 @@
steps: [
{
name: 'build-all-binary',
image: 'golang:1.13',
image: 'golang:1.14',
pull: 'always',
commands: [
'make release'
Expand Down