Conversation
| tabindex: 'testTabindex', | ||
| hl: 'testHl', | ||
| badge: 'testBadge' | ||
| }; |
There was a problem hiding this comment.
coding style? Is indent two space?
There was a problem hiding this comment.
Looks like indenting is tabs right now, should I change it to two spaces?
|
maybe we can drop the node 4 and 5 support. https://travis-ci.org/appleboy/react-recaptcha/builds/334740273 |
|
Node v6 was released in spring 2016, so dropping support for v4/5 seems ok. It looks like Travis is failing at the yarn build step, so maybe transitioning from yarn to npm could be an alternative to dropping v4/5 support. Npm has package-lock files now, and that was the primary benefit of yarn vs older versions of npm. |
|
@andyfry01 Could you help to switch |
|
Sure thing, I'll do a little research and let you know. |
|
Hey @appleboy, after looking into this more closely, it seems like the issue goes deeper than I could spend some more time on this, or if you don't mind dropping v4/5 support then that can be an option. |
|
@andyfry01 Maybe we can drop v4/5 support and update the message in README. OK? |
|
Hey @appleboy, updated the readme and dropped Node v4/5 from travis.yml. |
Hey @appleboy
Here is a PR for #221.
To summarize the changes:
test:watchscript to package.json so pre-commit doesn't get hung up because of the--watchflag on Jest.(also accidentally included 834f4ae, which was a commit for this PR. Forgot to switch branches before committing my unit test commits)
Thank you! Let me know if you have any question.
Andy