v1.0.4 #15
Merged
v1.0.4 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMS-7402 フォーム設定に不備がある場合、管理者用のエラーメッセージを表示する
sugawara-appleple
requested review from
1000-x-t30,
atsu666,
Copilot and
uidev1116
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the theme version from 1.0.3 to 1.0.4 and enhances form validation error handling with admin-specific messaging.
- Updated version numbers consistently across package files and documentation
- Replaced simple user-facing error messages with detailed admin-only validation error notifications
- Added permission-based error display using
Touch_SessionWithContributionto show diagnostic information only to contributors and above
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| themes/develop/package.json | Version updated to 1.0.4 |
| themes/develop/package-lock.json | Lockfile version synchronized to 1.0.4 |
| themes/develop/contact/form/main.twig | Enhanced error handling with admin-specific validation error notifications including form ID and field details |
| themes/develop/README.md | Documentation version updated to match 1.0.4 release |
Files not reviewed (1)
- themes/develop/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
atsu666
approved these changes
Nov 12, 2025
1000-x-t30
approved these changes
Nov 12, 2025
uidev1116
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.