Conversation
|
Ingress addon requires drivers to be something else other than "none" - the driver is docker by default. This requires a non-root user. This PR uses Ian's For |
leochr
left a comment
leochr
left a comment
There was a problem hiding this comment.
@halim-lee Thanks for the PR. Looks good. Since the majority of the tests are the same between ocp and minikube, it'll be good to add script to copy the existing tests, remove the ones that are not needed for minikube (i.e. route) and then add the tests for minikube (ingress).
| labels: | ||
| app.kubernetes.io/instance: probes-rc | ||
| name: probes-rc | ||
| spec: |
There was a problem hiding this comment.
Deployment resource and the .spec fields are duplicated in all the modified files.
| status: | ||
| readyReplicas: 1 | ||
| --- | ||
| apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
operator generates ingress with apiVersion networking.k8s.io/v1
Is this minikube specific?
There was a problem hiding this comment.
Hmm.. apiVersion: extensions/v1beta1 is what gets created in the Minikube cluster when expose is set to True. Minikube lists both networking.k8s.io/v1 and extensions/v1beta1 as supported. Not sure why the beta version is selected...
| mkdir -p $HOME/.kube $HOME/.minikube | ||
| touch $KUBECONFIG | ||
| sudo minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1 | ||
| minikube start --profile=minikube --kubernetes-version=v1.20.1 |
There was a problem hiding this comment.
Let's use kubectl 1.19 since OpenShift 4.6 (Long supported version) is at that level.
2 participants
What this PR does / why we need it?:
Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes:
Fixes #235