Conversation
arturdzm
force-pushed
the
byo-ca-and-issuer
branch
from
31b5b07 to
f01d9d9
Compare
leochr
reviewed
Nov 11, 2022
| @@ -448,7 +469,7 @@ func (r *ReconcilerBase) GenerateSvcCertSecret(ba common.BaseComponent, prefix s | |||
| bao := ba.(metav1.Object) | |||
|
|
|||
| err = r.GenerateCMIssuer(bao.GetNamespace(), prefix, CACommonName, operatorName) | |||
Member
There was a problem hiding this comment.
Should this be skipped if a custom issuer exists?
Contributor
Author
There was a problem hiding this comment.
I decided to leave this on just so that it is always there, and since default issuer / CA are not owned by application they will not be deleted with apps.
We might want to revisit in the future, just didn't want to add complexity of cleanup at this point
Member
There was a problem hiding this comment.
Okay, let's revisit. Agree that we don't need to clean up the default issuer and its resources, but the method call GenerateCMIssuer can be skipped if a custom issuer is used.
leochr
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.