Fix ready and reconcile status during upgrade#439
Merged
leochr merged 2 commits intoapplication-stacks:mainfrom Nov 29, 2022
Merged
Fix ready and reconcile status during upgrade#439leochr merged 2 commits intoapplication-stacks:mainfrom
leochr merged 2 commits intoapplication-stacks:mainfrom
Conversation
leochr
approved these changes
Nov 29, 2022
| // conditions for Ready and Reconciled are set to false | ||
| readyNewCondition := s.NewCondition(common.StatusConditionTypeReady) | ||
| readyNewCondition.SetStatus(corev1.ConditionFalse) | ||
| readyNewCondition.SetMessage("Resources not ready.") |
Member
There was a problem hiding this comment.
Suggestion: "Resources are not ready."
| s.SetCondition(readyNewCondition) | ||
| reconciledNewCondition := s.NewCondition(common.StatusConditionTypeReconciled) | ||
| reconciledNewCondition.SetStatus(corev1.ConditionFalse) | ||
| reconciledNewCondition.SetMessage("Resources not ready.") |
Member
There was a problem hiding this comment.
Suggestion: "Resources are not ready."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
When upgrading, and the Reconciled and Ready field are already set (possibly to true), and the ResourcesReady
condition becomes false again, set the Ready and Reconciled fields to reflect the overall new state.
Does this PR introduce a user-facing change?
CHANGELOG.mdWhich issue(s) this PR fixes:
Fixes #