Skip to content

Conversation

@smcclem
Copy link
Collaborator

@smcclem smcclem commented Mar 29, 2023

What this PR does / why we need it?:

Checks to see if there is an existing Deployment, Statefulset or Knative service with the same name, and verifies
if it is managed by another operator. If its not, the status is updated to reflect the issue and it is re-queued.

Does this PR introduce a user-facing change?
in addition to a summary of the change and link to the pull request.
-->

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes # WASdev/websphere-liberty-operator#179

@smcclem smcclem changed the title Issue#179 Handle k8s resource conflict due to same CR names Mar 29, 2023
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smcclem Thanks for the PR. Looks good for the most part. Added couple of comments.

@smcclem smcclem marked this pull request as ready for review March 31, 2023 16:43
@smcclem
Copy link
Collaborator Author

smcclem commented Mar 31, 2023

@leochr

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smcclem Thanks for the updates. Looks good

@leochr leochr merged commit f635163 into main Mar 31, 2023
@leochr leochr deleted the issue#179 branch March 31, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants