prometheus insists scheme is 'https' not 'HTTPS' #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of prometheus don't seem to like uppercase
arturdzm
reviewed
May 31, 2023
Dockerfile
Outdated
| FROM registry.access.redhat.com/ubi8 as builder | ||
| env PATH=$PATH:/usr/local/go/bin | ||
| RUN yum install -y wget | ||
| RUN wget --no-verbose --header "Accept: application/octet-stream" "https://golang.org/dl/go1.20.linux-amd64.tar.gz" -O - | tar -xz -C /usr/local/ |
Contributor
There was a problem hiding this comment.
I think we need this to be multi-platform (x86, ppc64le, etc) and different OS as well (Linux, MacOS, Windows)
This downloads 1.20 (not 1.20.x) version (1.20.4) latest
Collaborator
Author
There was a problem hiding this comment.
Sorry, that commit wasn't supposed to be part of the PR, that was an experiment. I'll remove it
arturdzm
approved these changes
Jun 2, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of prometheus don't seem to like uppercase
Currently the monitor test passes if you run against an OCP cluster, but fails in Kind clusters. This should now pass everywhere.
This looks like it has been caused by this commit in prometheus:
prometheus-operator/prometheus-operator@28e0383
which has added scheme validation, and only allows 'http' or 'https' as valid values.