Skip to content

Use latest transition time to adjust reconcile interval#680

Merged
leochr merged 5 commits intomainfrom
reconcile-time
Mar 7, 2025
Merged

Use latest transition time to adjust reconcile interval#680
leochr merged 5 commits intomainfrom
reconcile-time

Conversation

@halim-lee
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it?:

  • Use latest transition time to adjust the reconcile interval
  • Give users an option to hide reconcile interval
  • Max reconcile interval settings

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Related:

@halim-lee
Copy link
Copy Markdown
Collaborator Author

@halim-lee halim-lee force-pushed the reconcile-time branch 2 times, most recently from eec72bf to 1cf3dc8 Compare January 22, 2025 22:42
@halim-lee halim-lee requested a review from leochr February 19, 2025 21:54
Copy link
Copy Markdown
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Thank you for the PR and updates. Looks good for the most part. Added some comments and questions.

Comment thread api/v1/runtimecomponent_types.go Outdated
Comment thread utils/status.go Outdated
Comment thread utils/reconciler.go Outdated
Comment thread utils/reconciler.go Outdated
Comment thread utils/reconciler.go Outdated
Comment thread utils/reconciler.go Outdated
@halim-lee halim-lee changed the title Latest transition time to adjust reconcile interval Use latest transition time to adjust reconcile interval Mar 7, 2025
@leochr leochr added the vNext label Mar 7, 2025
Copy link
Copy Markdown
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Thank you for the quick updates! Looks good. Just one minor item to address.

Comment thread utils/reconciler.go Outdated
Copy link
Copy Markdown
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Thank you for the update. Looks good.

@leochr leochr merged commit 416cc2c into main Mar 7, 2025
@leochr leochr deleted the reconcile-time branch March 7, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants