This repository was archived by the owner on Aug 10, 2022. It is now read-only.
fix-ie-fullscreenshot #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirenik0
force-pushed
the
fix-ie-fullscreenshot
branch
from
7647bfc to
15bde90
Compare
eirenik0
added a commit
that referenced
this pull request
Aug 29, 2019
* Feature long request (#38) * feat: add to_rfc1123_datetime helper function; create datetime_utils * feat: add long_requests with check response * refactor: simplify request handling * refactor: use requests codes instead of numbers * refactor: simplify _long_request_loop mechanism * refactor: change `location` to capitalcase * test: update server_connector tests * test: add test for long_request * test: fix travis config * Fix full page screenshot in IE (#42) * refactor: EyesWebdriverScreenshot class simplification * test: add test_ie_viewport_screenshot * fix: ie always return full page screenshot If FPS cut it to VP size
itaibh
reviewed
Sep 9, 2019
| ) | ||
| driver.get("http://applitools.github.io/demo/TestPages/FramesTestPage") | ||
| eyes.open(driver, "Python SDK", "TestIEViewportScreenshot") | ||
| eyes.check_window() |
There was a problem hiding this comment.
What the stitch mode? Where do you check full page?
We need to run both viewport and full page on both CSS and Scroll stitch modes (4 permutations total).
Author
There was a problem hiding this comment.
Default stitch mode is Scroll. I'll add CSS stitch mode and FPS here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test result
https://eyes.applitools.com/app/test-results/00000251835215164238/00000251835215163255?accountId=xIpd7EWjhU6cjJzDGrMcUw~~
Origin issue
https://trello.com/c/YqLskoE9/876-python-4x-ie-11-always-full-page-screenshots