Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Conversation

@eirenik0
Copy link

@eirenik0 eirenik0 commented Aug 29, 2019

Feature long request (#38)

  • feat: add to_rfc1123_datetime helper function; create datetime_utils
  • feat: add long_requests with check response
  • refactor: simplify request handling
  • refactor: use requests codes instead of numbers
  • refactor: change location to capitalcase
  • test: add test for long_request
  • test: update server_connector tests

* feat: add to_rfc1123_datetime helper function; create datetime_utils

* feat: add long_requests with check response

* refactor: simplify request handling

* test: update server_connector tests

* refactor: use requests codes instead of numbers

* refactor: simplify _long_request_loop mechanism

* refactor: change `location` to capitalcase

* test: add test for long_request

# Conflicts:
#	eyes_core/applitools/core/server_connector.py
@nikita-andreev
Copy link

353954b - looks good for me

* refactor: EyesWebdriverScreenshot class simplification

* test: add test_ie_viewport_screenshot

* fix: ie always return full page screenshot

   If FPS cut it to VP size
@eirenik0 eirenik0 merged commit a7bc624 into master Aug 29, 2019
@eirenik0 eirenik0 deleted the release-4.0.8 branch December 8, 2019 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants