Skip to content

Custom traffic icons feature based on ADSB-reported aircraft and flight properties (relative altitude, vertical speed, velocity)#2

Merged
apps4av merged 1 commit into
apps4av:masterfrom
shanelenagh:PR_traffic_icons_squashmerge
Mar 21, 2024
Merged

Custom traffic icons feature based on ADSB-reported aircraft and flight properties (relative altitude, vertical speed, velocity)#2
apps4av merged 1 commit into
apps4av:masterfrom
shanelenagh:PR_traffic_icons_squashmerge

Conversation

@shanelenagh
Copy link
Copy Markdown
Contributor

@shanelenagh shanelenagh commented Mar 21, 2024

…nd flight properties such as relative altitude, vertical speed, and velocity/horizontal speed)

Squashed commit of the following:

commit fde7a4018b7b3f6ad4018c56949dc788a710e3b1
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 16:23:49 2024 -0500

Much comment and naming cleanup from final review before PR

commit 7153133939232663fba8452db6ecf93cb325b6e1
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 16:20:20 2024 -0500

Need to accept current alt (even if it looks like trash, e.g., is negative) not abs it

commit 3abbc0e
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 15:44:23 2024 -0500

Snapping my latest test harness before I start PR

commit dfe5562
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 14:50:30 2024 -0500

Minor large and light aircraft item touches

commit dfe63b2
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 11:33:23 2024 -0500

Speed barb calculation and rendering bug fixes

commit 298657b
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 10:33:06 2024 -0500

Tweaked speed barb to be smaller, and did some commenting and var name refactoring

commit 664d0ae
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 10:32:10 2024 -0500

Added traffic icon cache to speed rendering of identical images (massively and demonstrably increases FPS headroom and eliminates jank, according to DevTools perf monitor)

commit 4cdb837
Author: Shane Lenagh shanelenagh@gmail.com
Date: Thu Mar 21 08:39:20 2024 -0500

Several icon tweaks

commit 6db7f41
Author: Shane Lenagh shanelenagh@gmail.com
Date: Wed Mar 20 23:04:31 2024 -0500

All icon paths should be static--only need to construct once

commit 805f424
Author: Shane Lenagh shanelenagh@gmail.com
Date: Wed Mar 20 22:57:05 2024 -0500

WIP with asc/desc and icon improvements

commit 23cb1cc
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 15:40:16 2024 -0500

Tweaked level (grey) aircraft color a bit more, to balance OSM and non-OSM contrast

commit 51d9a63
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 13:19:24 2024 -0500

Changed colors again for OSM (level was black, which was invisible) and color-blind contrast

commit e87cf51
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 13:02:21 2024 -0500

Brightened blue even more for greater no-OSM (black) contrast

commit 181ea9c
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 12:51:43 2024 -0500

Made blue a little lighter for when OSM is off

commit 327ed96
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 12:30:14 2024 -0500

More cleanup for PR and review

commit 2a5b548
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 11:28:25 2024 -0500

Converted a few more divisions to const multiplies (micro-opt, I know)

commit 9278afd
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 10:32:20 2024 -0500

Clean up format in preparation for PR

commit 56955ef
Merge: 44a4d3d 9584952
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 09:12:21 2024 -0500

Merge branch 'traffic_icons' of github.com:shanelenagh/avaremp into traffic_icons

commit 44a4d3d
Author: Shane Lenagh shanelenagh@gmail.com
Date: Tue Mar 19 09:10:42 2024 -0500

Made opacity on flight levels more dramatic, removed unecessary cast on repaint check, and added more comments

commit 9584952
Author: shanelenagh shanelenagh@users.noreply.github.com
Date: Mon Mar 18 21:49:51 2024 -0500

Simplified shouldrepaint

commit eb7e117
Author: Shane Lenagh shanelenagh@gmail.com
Date: Mon Mar 18 16:46:11 2024 -0500

Added rotorcraft-specific icon

commit fcdbb49
Merge: 93e0824 ef55e21
Author: Shane Lenagh shanelenagh@gmail.com
Date: Mon Mar 18 09:15:36 2024 -0500

Merge branch 'upstream' into traffic_icons

commit 93e0824
Author: Shane Lenagh shanelenagh@gmail.com
Date: Mon Mar 18 08:51:11 2024 -0500

Finished out first cut of drawn traffic icons

commit 5a78390
Author: Shane Lenagh shanelenagh@gmail.com
Date: Sun Mar 17 06:40:35 2024 -0500

WIP of traffic icons

commit 17800cf
Author: Shane Lenagh shanelenagh@gmail.com
Date: Sat Mar 16 14:29:52 2024 -0500

Playground for new traffic icons

@shanelenagh
Custom traffic icons feature (based on ADSB-reported aircraft type, a…
c87e5f7 
…nd flight properties such as relative altitude, vertical speed, and velocity/horizontal speed)

Squashed commit of the following:

commit fde7a4018b7b3f6ad4018c56949dc788a710e3b1
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 16:23:49 2024 -0500

    Much comment and naming cleanup from final review before PR

commit 7153133939232663fba8452db6ecf93cb325b6e1
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 16:20:20 2024 -0500

    Need to accept current alt (even if it looks like trash, e.g., is negative) not abs it

commit 3abbc0e
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 15:44:23 2024 -0500

    Snapping my latest test harness before I start PR

commit dfe5562
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 14:50:30 2024 -0500

    Minor large and light aircraft item touches

commit dfe63b2
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 11:33:23 2024 -0500

    Speed barb calculation and rendering bug fixes

commit 298657b
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 10:33:06 2024 -0500

    Tweaked speed barb to be smaller, and did some commenting and var name refactoring

commit 664d0ae
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 10:32:10 2024 -0500

    Added traffic icon cache to speed rendering of identical images (massively and demonstrably increases FPS headroom and eliminates jank, according to DevTools perf monitor)

commit 4cdb837
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Thu Mar 21 08:39:20 2024 -0500

    Several icon tweaks

commit 6db7f41
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Wed Mar 20 23:04:31 2024 -0500

    All icon paths should be static--only need to construct once

commit 805f424
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Wed Mar 20 22:57:05 2024 -0500

    WIP with asc/desc and icon improvements

commit 23cb1cc
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 15:40:16 2024 -0500

    Tweaked level (grey) aircraft color a bit more, to balance OSM and non-OSM contrast

commit 51d9a63
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 13:19:24 2024 -0500

    Changed colors again for OSM (level was black, which was invisible) and color-blind contrast

commit e87cf51
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 13:02:21 2024 -0500

    Brightened blue even more for greater no-OSM (black) contrast

commit 181ea9c
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 12:51:43 2024 -0500

    Made blue a little lighter for when OSM is off

commit 327ed96
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 12:30:14 2024 -0500

    More cleanup for PR and review

commit 2a5b548
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 11:28:25 2024 -0500

    Converted a few more divisions to const multiplies (micro-opt, I know)

commit 9278afd
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 10:32:20 2024 -0500

    Clean up format in preparation for PR

commit 56955ef
Merge: 44a4d3d 9584952
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 09:12:21 2024 -0500

    Merge branch 'traffic_icons' of github.com:shanelenagh/avaremp into traffic_icons

commit 44a4d3d
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Tue Mar 19 09:10:42 2024 -0500

    Made opacity on flight levels more dramatic, removed unecessary cast on repaint check, and added more comments

commit 9584952
Author: shanelenagh <shanelenagh@users.noreply.github.com>
Date:   Mon Mar 18 21:49:51 2024 -0500

    Simplified shouldrepaint

commit eb7e117
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Mon Mar 18 16:46:11 2024 -0500

    Added rotorcraft-specific icon

commit fcdbb49
Merge: 93e0824 ef55e21
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Mon Mar 18 09:15:36 2024 -0500

    Merge branch 'upstream' into traffic_icons

commit 93e0824
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Mon Mar 18 08:51:11 2024 -0500

    Finished out first cut of drawn traffic icons

commit 5a78390
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Sun Mar 17 06:40:35 2024 -0500

    WIP of traffic icons

commit 17800cf
Author: Shane Lenagh <shanelenagh@gmail.com>
Date:   Sat Mar 16 14:29:52 2024 -0500

    Playground for new traffic icons
@apps4av apps4av merged commit 0db7cc9 into apps4av:master Mar 21, 2024
apps4av added a commit that referenced this pull request May 26, 2026
@apps4av @cursoragent
Harden Community Firestore rules against tampering and enumeration
c34ee58 
Fixes the security audit findings on the v1 Community rules. All
changes are rules-only except a small members-screen tweak so that
non-members of private groups see a friendly message instead of a raw
permission-denied error.

Critical / high:
- Counter updates now require an exact +/-1 delta and forbid negative
  values, instead of allowing any signed-in user to set memberCount
  and postCount to arbitrary numbers (audit #1). Long-term fix is a
  Cloud Function trigger; documented in the rules file.
- All user-writable documents (profile, group, member, post,
  userGroups index) are now whitelisted on field keys and validated
  on types, lengths, and enum values, closing latent privilege
  escalation paths and DoS via oversized documents (audit #2, #4, #8,
  #12, #13).
- Removed the unconstrained isGroupOwner(gid) branch on member create.
  Owner approvals now flow through update of an existing pending doc,
  with status pinned to pending -> active and role/joinedAt frozen
  (audit #3).

Medium:
- Member rosters are no longer enumerable by strangers. Reads of
  groups/{gid}/members require self, owner, public visibility, or
  active membership (audit #6).
- Posts are now bounded to 1000 characters at the rule level (audit
  #7) and to a fixed field whitelist (audit #8).

Hardening:
- isActiveMember consolidated to a single get() lookup pattern via
  helper functions (audit #10 partial).
- All timestamps validated as `is timestamp`; full server-timestamp
  enforcement deferred to a future Cloud Function (audit #13).

Knowingly not fixed in v1 (documented inline):
- Group metadata visibility: the group doc remains readable by any
  signed-in pilot so the Discover tab can surface private groups by
  name. Sensitive future fields must live in a separate restricted
  subcollection (audit #5).
- Counter drift under adversarial use: ruled-bounded to +/-1 per call;
  long-term fix requires Cloud Functions (audit #11).
- Owners can technically self-delete their membership through this
  rule; rules cannot distinguish "owner leaves" from "owner deletes
  group". The client repository blocks owner-leave at call time
  (audit #9).

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apps4av apps4av apps4av approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shanelenagh @apps4av