Modernize CI/publish workflows#563
Merged
Merged
Conversation
- ci.yml: checkout before setup-go so module caching works; add read-only permissions block. - publish.yml: install awscli via apt (avoids PEP 668 breakage on ubuntu-24.04), drop deprecated hub CLI install, lift GITHUB_USER to job env, switch R2 endpoint to AWS_ENDPOINT_URL env var, add read-only permissions block. - update-release-tracker.sh: replace archived `hub api` with pre-installed `gh api`. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Org policy requires actions to be pinned to a full-length commit SHA. - actions/checkout@v4 -> 34e1148 (v4.3.1) - actions/setup-go@v5 -> 40f1582 (v5.6.0) Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkoutbeforesetup-gosoactions/setup-go@v5's built-in module caching can findgo.sum; addpermissions: contents: read.awscliviaaptinstead ofpip3(PEP 668 makes system pip installs error on ubuntu-24.04); drop the archivedgithub/hubinstall step sinceghis pre-installed on the runner; replace the non-standardaws configure set endpoint_urlwithAWS_ENDPOINT_URLenv on the Publish step (supported in AWS CLI v2.13+); liftGITHUB_USER: 1gtmto job-level env; addpermissions: contents: read.hub apitogh api(same flags, sameGITHUB_TOKENenv pickup).Test plan
master:apt-get install awsclisucceeds.aws s3 syncreaches the R2 bucket viaAWS_ENDPOINT_URL.gh apiposts the/taggedcomment to the release tracker.