feat: migrate from org to workspace under phase 3 by ankitakinger · Pull Request #14158 · appsmithorg/appsmith

ankitakinger · 2022-05-30T06:27:22Z

Description

Migrate organization to workspace by renaming remaining FE changes on the UI viewable to the user.

Fixes #13770

Type of change

Refactoring of old feature

How Has This Been Tested?

CI tests
Tested UI to look as expected

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…o feat/migrate_to_workspaces

…ontrollers/ce/ApplicationControllerCE.java

…rnal/models/Datasource.java Co-authored-by: Trisha Anand <trisha@appsmith.com>

…o feat/migrate_to_workspaces_phase3

ankitakinger · 2022-06-24T04:28:40Z

/ok-to-test sha=9fe140a

github-actions · 2022-06-24T04:58:31Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2553598269.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9fe140a.
PR: 14158.

github-actions · 2022-06-24T05:54:26Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2553598269.
Commit: 9fe140a.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	720.04	796.11	783.81	857.53	881.33	796.11	807.76	7.90	7.07
painting	5.88	6.73	6.17	20.61	5.3	6.17	8.94	73.27	65.44
rendering	377.55	396.44	397.1	388.6	487.4	396.44	409.42	10.82	9.68
BIND_TABLE_DATA
scripting	2264.15	2292.21	2209.82	2235.49	2053.84	2235.49	2211.1	4.21	3.77
painting	13.79	29.41	24.75	25.13	25.18	25.13	23.65	24.65	22.07
rendering	905.63	1073.46	1120.85	949.68	1120.64	1073.46	1034.05	9.69	8.67
CLICK_ON_TABLE_ROW
scripting	1784.84	2207.18	2243.49	2347.34	1677.71	2207.18	2052.11	14.61	13.07
painting	22.91	19.92	26.4	18.07	13.55	19.92	20.17	24.10	21.57
rendering	367.61	395.99	504.88	443.49	366.63	395.99	415.72	14.15	12.65
UPDATE_POST_TITLE
scripting	2791.03	3411.57	3758.59	3527.77	3301.26	3411.57	3358.04	10.70	9.57
painting	36.52	30.36	42.38	22.92	19.68	30.36	30.37	30.89	27.63
rendering	475.9	574.78	602.86	557.34	533.36	557.34	548.85	8.75	7.83
OPEN_MODAL
scripting	1449.78	1303.31	1645.5	1427.82	1389.52	1427.82	1443.19	8.74	7.82
painting	12.07	20.3	21.44	12.54	12.56	12.56	15.78	29.59	26.43
rendering	582.34	593.97	694.83	633.53	596.28	596.28	620.19	7.41	6.63
CLOSE_MODAL
scripting	792.32	886.37	880	746.69	2378.11	880	1136.7	61.27	54.80
painting	6.83	6.89	7.92	6.61	14.1	6.89	8.47	37.66	33.65
rendering	556.17	523.27	675.84	513.72	488.4	523.27	551.48	13.35	11.94
SELECT_WIDGET_MENU_OPEN
scripting	1449.88	1469.39	1489.98	1579.89	1676.66	1489.98	1533.16	6.16	5.51
painting	10.85	10.55	8.66	18.27	11.09	10.85	11.88	31.14	27.86
rendering	790.64	803.27	814.65	851.52	892.75	814.65	830.57	5.00	4.47
SELECT_WIDGET_SELECT_OPTION
scripting	264.76	221.4	254.48	307.39	261.89	261.89	261.98	11.72	10.49
painting	8.13	5	7.03	6.15	8.62	7.03	6.99	21.03	18.74
rendering	19.18	19.15	20.97	16.98	21.78	19.18	19.61	9.48	8.52

…o feat/migrate_to_workspaces_phase3

ankitakinger · 2022-07-12T09:45:45Z

/ok-to-test sha=c947116

github-actions · 2022-07-12T09:46:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2655613504.
Workflow: Appsmith External Integration Test Workflow.
Commit: c947116.
PR: 14158.

github-actions · 2022-07-13T08:03:44Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2655613504.
Workflow: Appsmith External Integration Test Workflow.
Commit: c947116.
PR: 14158.

github-actions · 2022-07-13T08:43:41Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2655613504.
Commit: c947116.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1129.65	1104.87	1124.68	1119.27	1081.12	1119.27	1111.92	1.76	1.57
painting	6.45	6.09	6.18	7.68	6.47	6.45	6.57	9.74	8.68
rendering	594.4	605.91	608.9	596.95	574.57	596.95	596.15	2.26	2.02
SELECT_WIDGET_SELECT_OPTION
scripting	157.91	155.78	164.35	143.6	165.1	157.91	157.35	5.51	4.93
painting	6.52	4.92	2.49	2.55	6.73	4.92	4.64	44.40	39.66
rendering	10.02	9.01	10.1	9.88	9.98	9.98	9.8	4.59	4.08

ankitakinger · 2022-07-13T10:22:57Z

/ok-to-test sha=47959f4

github-actions · 2022-07-13T11:03:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2662876170.
Workflow: Appsmith External Integration Test Workflow.
Commit: 47959f4.
PR: 14158.

github-actions · 2022-07-13T11:42:24Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2662876170.
Commit: 47959f4.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1085.5	1105.42	1106.72	1152.76	1093.5	1105.42	1108.78	2.35	2.11
painting	4.83	5.78	5.38	5.39	10.76	5.39	6.43	38.10	34.06
rendering	590.15	588.72	595.93	586.43	590.31	590.15	590.31	0.59	0.53
SELECT_WIDGET_SELECT_OPTION
scripting	155.51	153.16	166.26	155.81	150.92	155.51	156.33	3.77	3.37
painting	10.93	8.67	8.99	6.48	13.37	8.99	9.69	26.73	23.94
rendering	9.83	8.73	10.01	10.13	9.33	9.83	9.61	6.04	5.41

ankitakinger · 2022-07-13T13:00:54Z

/ok-to-test sha=3a7689d

github-actions · 2022-07-13T13:01:32Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2663592340.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a7689d.
PR: 14158.

github-actions · 2022-07-13T13:30:38Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2663592340.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a7689d.
PR: 14158.

github-actions · 2022-07-13T14:12:51Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2663592340.
Commit: 3a7689d.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1235.96	1145.39	1144.32	1159.14	1169.06	1159.14	1170.77	3.23	2.89
painting	15.04	6.38	6.72	5.87	17.11	6.72	10.22	52.84	47.26
rendering	645.95	592.88	595.05	615.1	626.84	615.1	615.16	3.62	3.24
SELECT_WIDGET_SELECT_OPTION
scripting	153.94	151.46	157.16	155.91	153.24	153.94	154.34	1.45	1.30
painting	4.01	2.16	10.46	2.59	4.87	4.01	4.82	69.29	61.83
rendering	10.5	11.85	9.96	10.89	9.43	10.5	10.53	8.74	7.88

ghost · 2022-07-13T14:47:16Z

app/client/cypress/integration/Smoke_TestSuite/Application/ImportExportForkApplication_spec.js

        cy.generateUUID().then((uid) => {
          workspaceId = uid;
-          localStorage.setItem("OrgName", workspaceId);
+          localStorage.setItem("WorkspaceName", workspaceId);


I am seeing only setItem and no getItem.

ankitakinger and others added 30 commits May 13, 2022 23:40

migration from organization to workspace on code level

b58b3be

updated a few more files

d2942ac

fixed runtime errors

6211f5d

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

95d7c59

…o feat/migrate_to_workspaces

update org settings URL

f8ec784

Merge branch 'release' into feat/migrate_to_workspaces

229800a

Renamed organizationId in domain objects

44c92c7

changed field named from organization to workspace

4cfe011

Reverted AppsmithRole changes

9c84e93

fixed migrations

4ae1920

recreating indexes

4ef081b

migration update

965cf03

Merge branch 'release' into feat/migrate_to_workspaces

d7c9b8b

seed data runs before migration, undo changes

364e435

mock commit

1d094c0

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

83d9d0a

…o feat/migrate_to_workspaces

seedmongo to populate upgraded data, datasource upgrade

ccdac52

fixed two test cases

db03182

updated migrations

e8f8417

updated prop name

ed9a7dd

Upgraded AclPermission

ad29894

comment

e66eb34

migrated AppsmithRole

4d86704

more changes

7dcab1f

final set of changes

58dae21

variable name changes

e5cd228

update cypress variable name

c3f39b4

Update app/server/appsmith-server/src/main/java/com/appsmith/server/c…

78457ea

…ontrollers/ce/ApplicationControllerCE.java

Update app/server/appsmith-interfaces/src/main/java/com/appsmith/exte…

00b26f8

…rnal/models/Datasource.java Co-authored-by: Trisha Anand <trisha@appsmith.com>

reverting encryption handler change

585ba2f

vercel bot deployed to Preview – appsmith June 21, 2022 05:26 View deployment

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

9fe140a

…o feat/migrate_to_workspaces_phase3

vercel bot had a problem deploying to Preview – appsmith June 23, 2022 16:01 Failure

Nikhil-Nandagopal removed the Platform Pod label Jun 27, 2022

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

c947116

…o feat/migrate_to_workspaces_phase3

vercel bot had a problem deploying to Preview – appsmith July 12, 2022 07:43 Failure

fixed failing cypress test

47959f4

vercel bot had a problem deploying to Preview – appsmith July 13, 2022 10:23 Failure

fixed failing cypress test

3a7689d

vercel bot had a problem deploying to Preview – appsmith July 13, 2022 13:01 Failure

ankitakinger requested review from a user, sidhantgoel and trishaanand July 13, 2022 14:40

ghost approved these changes Jul 13, 2022

View reviewed changes

ankitakinger merged commit 3933f5f into release Jul 20, 2022

ankitakinger deleted the feat/migrate_to_workspaces_phase3 branch July 20, 2022 11:54

Comments

Conversation

ankitakinger commented May 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

ankitakinger commented Jun 24, 2022

Uh oh!

github-actions bot commented Jun 24, 2022

Uh oh!

github-actions bot commented Jun 24, 2022

Uh oh!

ankitakinger commented Jul 12, 2022

Uh oh!

github-actions bot commented Jul 12, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

ankitakinger commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

ankitakinger commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

ghost Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ankitakinger commented May 30, 2022 •

edited

Loading