Skip to content

Comments

ci: Fixing the RTS build workflow#16748

Merged
mohanarpit merged 8 commits intoappsmithorg:releasefrom
mohanarpit:release
Sep 14, 2022
Merged

ci: Fixing the RTS build workflow#16748
mohanarpit merged 8 commits intoappsmithorg:releasefrom
mohanarpit:release

Conversation

@mohanarpit
Copy link
Member

Description

The problem with the RTS workflow after the induction of AST parsing was that while copying the node_modules, Ubuntu doesn't follow the symlink and copy the content. It simply copies the symlink as is. This causes issues for RTS service to start.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Personal repository

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 14, 2022

@mohanarpit is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 8:42AM (UTC)

@mohanarpit mohanarpit added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 14, 2022
@mohanarpit mohanarpit merged commit 7580eb9 into appsmithorg:release Sep 14, 2022
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants