feat: Auto height instant update #19082
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/perf-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3764339506. |
…t and Tabs widget, as well as the canvas default height
…uto-height-instant-update
riodeuno
added
Enhancement
…uto-height-instant-update
github-actions
bot
added
Bug
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4075423889. |
The following are new failures, please fix them before merging the PR |
|
The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/Application/PgAdmin_spec.js |
The following are new failures, please fix them before merging the PR |
|
The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js |
The following are new failures, please fix them before merging the PR |
|
The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js |
The following are new failures, please fix them before merging the PR |
|
The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js |
|
/ok-to-test sha=6b800ad |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4076423470. |
github-actions
bot
added
Sentry
|
With this PR , do we expect fix for the issue where scrollbars were coming in deploy mode when border width was increased for container type(auto height) widgets ? @riodeuno |
github-actions
bot
added
Bug
|
@kamakshibhat-appsmith Yes, this PR should have fixed that. I can replicate this on release right now. Let me look into this. |
github-actions
bot
added
Bug
…xed height container (#41178) ## Description Removing a line of code to fix extra space issue on Page with Fixed height container once switched from a Page with Auto height container. Also, manually tested out all issues from [#19082](#19082) to confirm nothing else breaks from the time these lines were added in the code. Fixes [#41180](#41180) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/17043252133> > Commit: c8bde12 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=17043252133&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 18 Aug 2025 17:04:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved main container auto-height calculation to eliminate unintended extra spacing, resulting in more accurate, content-driven sizing. * **Chores** * Added diagnostic logging around main container size computation in view mode to aid troubleshooting (no functional impact). <!-- end of auto-generated comment: release notes by coderabbit.ai -->
6 participants
Description
This PR adds one of the promised updates to the Auto-height feature---to see containers change height as we drag and drop widgets within them instead of after dropping these widgets.
Display Auto-height updates during drag and resize, instead of after. See video below.
Include scrollbars within borders of the container like widgets such that the borders are not overridden by scrollbars and auto height considers border thickness for computations
Make Container widgets leaner by reducing the number of DOM nodes which make up a container-like widget. This reduces the load on the browser, so that it doesn't have to render as many DOM nodes as before. So, this is improving rendering performance, however, it may not be noticeable, as it is in milliseconds. We haven't registered any metrics for this, as this falls in the best practices category instead of the performance improvement category.
Fixes #19216
Fixes #19578
Fixes #19579
Fixes #20421
Media
Auto.height.with.instant.feedback.mov
Type of change
How Has This Been Tested?
This involves drag and drop and will not have cypress tests.
Test Plan
https://github.com/appsmithorg/TestSmith/issues/2145
Issues raised during DP testing
#19082 (comment)
#19082 (comment)
#19082 (comment)
Checklist:
Dev activity
QA activity: