Skip to content

fix: Updating logic to push blank key value params based on manage access for APIs#19722

Merged
ankitakinger merged 6 commits intoreleasefrom
fix/query-execution-stuck
Jan 13, 2023
Merged

fix: Updating logic to push blank key value params based on manage access for APIs#19722
ankitakinger merged 6 commits intoreleasefrom
fix/query-execution-stuck

Conversation

@ankitakinger
Copy link
Copy Markdown
Contributor

@ankitakinger ankitakinger commented Jan 11, 2023 •
edited
Loading

Description

Updating logic to push blank key value params based on manage access for APIs.

Fixes #19253

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Followed the steps in the linked issue and it works now as expected.

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 1:20PM (UTC)

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jan 11, 2023

  • In CommonEditorForm.tsx, the pushFields prop was added to two components:
    • ActionConfigurationHeadersTable
    • ActionConfigurationQueryParametersTable

@github-actions github-actions bot added Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage RBAC Product Issues, requests and enhancements around RBAC. Platform Administration Pod Issues related to platform administration & management labels Jan 11, 2023
@ankitakinger
Copy link
Copy Markdown
Contributor Author

ankitakinger commented Jan 11, 2023

/ok-to-test sha=8b1a652

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3890767817.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8b1a652.
PR: 19722.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19722&runId=3890767817_1

albinAppsmith
albinAppsmith previously approved these changes Jan 11, 2023
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ForkApplication_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js

@ankitakinger
Copy link
Copy Markdown
Contributor Author

ankitakinger commented Jan 11, 2023

/ok-to-test sha=d9fff56

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3893681882.
Workflow: Appsmith External Integration Test Workflow.
Commit: d9fff56.
PR: 19722.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19722&runId=3893681882_1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 11, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js

@ankitakinger
Copy link
Copy Markdown
Contributor Author

ankitakinger commented Jan 12, 2023

/ok-to-test sha=94a58fc

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3902572768.
Workflow: Appsmith External Integration Test Workflow.
Commit: 94a58fc.
PR: 19722.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19722&runId=3902572768_1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js

@ankitakinger ankitakinger merged commit 3a3d512 into release Jan 13, 2023
@ankitakinger ankitakinger deleted the fix/query-execution-stuck branch January 13, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@albinAppsmith albinAppsmith albinAppsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management RBAC Product Issues, requests and enhancements around RBAC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The execution of the API goes to Infinite loading in edit mode when API just have View and execute permission

2 participants

@ankitakinger @albinAppsmith