Skip to content

feat: Git actions queue#20258

Merged
hetunandu merged 1 commit intoreleasefrom
feature/git-action-lock
Feb 1, 2023
Merged

feat: Git actions queue#20258
hetunandu merged 1 commit intoreleasefrom
feature/git-action-lock

Conversation

@hetunandu
Copy link
Copy Markdown
Member

@hetunandu hetunandu commented Jan 31, 2023 •
edited
Loading

Description

We will queue all requests to the git api to match the implementation on the server. This way we do not have parallel git related requests to the server which could cause weird ui behaviour.

Queue git related actions from client to improve stability

Fixes #20218

Media

Screen.Recording.2023-01-31.at.5.01.10.PM.mov

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@hetunandu hetunandu requested a review from a user January 31, 2023 11:19
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 11:23AM (UTC)

@github-actions github-actions bot added Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Enhancement New feature or request labels Jan 31, 2023
@hetunandu
Copy link
Copy Markdown
Member Author

hetunandu commented Jan 31, 2023

/ok-to-test sha=8a994e3fb7192233710ef4996142fbcdbf66200c

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4055585100.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8a994e3fb7192233710ef4996142fbcdbf66200c.
PR: 20258.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20258&runId=4055585100_1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2023

The following are new failures, please fix them before merging the PR

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/CategroySlider_spec.ts

@Parthvi12 Parthvi12 added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Feb 1, 2023
@hetunandu hetunandu merged commit fb72dd7 into release Feb 1, 2023
@hetunandu hetunandu deleted the feature/git-action-lock branch February 1, 2023 11:55
AnaghHegde added a commit that referenced this pull request Feb 13, 2023
@AnaghHegde
Revert "feat: Git actions queue (#20258)"
95b778d 
This reverts commit fb72dd7.
@AnaghHegde AnaghHegde mentioned this pull request Feb 17, 2023
Merged
mohanarpit pushed a commit that referenced this pull request Feb 20, 2023
@AnaghHegde
chore: Undo the git actions queue changes (#20749)
002b776 
Changes made in the PR -
#20258 were reverted by file
lock PR to test a few scenarios but forgot to undo them and got merged
to release.
So this PR adds the changes done by the original PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement New feature or request Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow only one git operation to occur at once in the client

2 participants

@hetunandu @Parthvi12