Skip to content

fix: revert color change#21161

Merged
prsidhu merged 2 commits intoreleasefrom
fix/revert_color_change
Mar 6, 2023
Merged

fix: revert color change#21161
prsidhu merged 2 commits intoreleasefrom
fix/revert_color_change

Conversation

@prsidhu
Copy link
Contributor

@prsidhu prsidhu commented Mar 6, 2023

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ❌ Failed (Inspect) Mar 6, 2023 at 9:32AM (UTC)

@prsidhu prsidhu requested a review from marks0351 March 6, 2023 04:28
@prsidhu
Copy link
Contributor Author

prsidhu commented Mar 6, 2023

/ok-to-test sha=17c9591

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4339957867.
Workflow: Appsmith External Integration Test Workflow.
Commit: 17c9591.
PR: 21161.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21161&runId=4339957867_1

@marks0351 marks0351 changed the title revert color change Fix: revert color change Mar 6, 2023
@marks0351 marks0351 changed the title Fix: revert color change fix: revert color change Mar 6, 2023
@github-actions github-actions bot added the Bug Something isn't working label Mar 6, 2023
@prsidhu prsidhu enabled auto-merge (squash) March 6, 2023 04:42
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/Form_With_CheckBox_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/DeleteWorkspace_spec.js
  3. cypress/integration/Regression_TestSuite/UpgradeAppsmith/UpgradeAppsimth_spec.js

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/Form_With_CheckBox_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/DeleteWorkspace_spec.js
  3. cypress/integration/Regression_TestSuite/UpgradeAppsmith/UpgradeAppsimth_spec.js

@prsidhu
Copy link
Contributor Author

prsidhu commented Mar 6, 2023

/ok-to-test sha=19061fa

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4341805020.
Workflow: Appsmith External Integration Test Workflow.
Commit: 19061fa.
PR: 21161.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21161&runId=4341805020_1

@prsidhu prsidhu merged commit 6fb1136 into release Mar 6, 2023
@prsidhu prsidhu deleted the fix/revert_color_change branch March 6, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants