fix: fetch gsheet project id from cs added by sneha122 · Pull Request #21361 · appsmithorg/appsmith

sneha122 · 2023-03-13T10:17:22Z

Description

File picker implementation for Limiting Gsheet Access requires google sheet project id. The changes in this PR gets the gsheet project id from cloud-services and returns it back to client. Client then uses this project id to open file picker and select required files.

Fixes #21298, #21362

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

sneha122 · 2023-03-13T10:19:15Z

/ok-to-test

github-actions · 2023-03-13T10:19:42Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4403790741.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4403790741_1

sneha122 · 2023-03-13T10:22:35Z

/build-deploy-preview

github-actions · 2023-03-13T10:23:12Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4403821161.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

github-actions · 2023-03-13T10:53:20Z

Deploy-Preview-URL: https://ce-21361.dp.appsmith.com

github-actions · 2023-03-13T11:41:10Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/CreateNewApp_spec.js

sneha122 · 2023-03-13T12:32:32Z

/build-deploy-preview

github-actions · 2023-03-13T12:32:57Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4404927584.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

sneha122 · 2023-03-13T12:44:46Z

/ok-to-test

github-actions · 2023-03-13T12:45:13Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4405032123.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4405032123_1

sneha122 · 2023-03-14T06:12:22Z

/ok-to-test

github-actions · 2023-03-14T06:12:47Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4412784893.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4412784893_1

sumitsum · 2023-03-14T06:16:02Z

Server side changes LGTM.

sneha122 · 2023-03-14T09:24:19Z

/ok-to-test

github-actions · 2023-03-14T09:24:47Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4414142010.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4414142010_1

sneha122 · 2023-03-20T07:53:59Z

/ok-to-test

github-actions · 2023-03-20T07:54:36Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4465887797.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4465887797_1

sneha122 · 2023-03-20T08:33:05Z

/build-deploy-preview

github-actions · 2023-03-20T08:33:31Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4466187299.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

github-actions · 2023-03-20T09:07:05Z

Deploy-Preview-URL: https://ce-21361.dp.appsmith.com

sneha122 · 2023-03-20T10:10:35Z

/build-deploy-preview

github-actions · 2023-03-20T10:11:04Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4467015729.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

github-actions · 2023-03-20T10:43:47Z

Deploy-Preview-URL: https://ce-21361.dp.appsmith.com

sneha122 · 2023-03-20T11:16:20Z

/build-deploy-preview

github-actions · 2023-03-20T11:16:45Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4467582463.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

github-actions · 2023-03-20T11:47:22Z

Deploy-Preview-URL: https://ce-21361.dp.appsmith.com

sneha122 · 2023-03-20T13:16:53Z

/ok-to-test

github-actions · 2023-03-20T13:17:23Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4468632952.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21361.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21361&runId=4468632952_1

github-actions · 2023-03-20T15:08:54Z

The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

sneha122 · 2023-03-21T05:46:53Z

/build-deploy-preview

github-actions · 2023-03-21T05:47:14Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4475948324.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21361.

github-actions · 2023-03-21T06:19:35Z

Deploy-Preview-URL: https://ce-21361.dp.appsmith.com

sneha122 · 2023-03-21T07:18:27Z

This PR cannot be tested on DP, as DP generated with build-deploy-preview does not have cloud-services configured correctly. Hence as per this thread, we have decided to merge the PR and test the changes on release. CC: @prapullac @rohan-arthur

prapullac · 2023-03-21T07:21:51Z

As per above comment adding the label.

fix: fetch gsheet project id from cs added

a7942d3

github-actions bot added Query & JS Pod Issues related to the query & JS Pod Bug Something isn't working Google Sheets Issues related to Google Sheets Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Release labels Mar 13, 2023

sneha122 requested review from Irongade and sumitsum March 13, 2023 10:18

fix: file not getting selected issue fixed

fffee83

sumitsum suggested changes Mar 13, 2023

View reviewed changes

Comment thread ...smith-server/src/main/java/com/appsmith/server/solutions/ce/AuthenticationServiceCEImpl.java Outdated

Comment thread ...r/appsmith-interfaces/src/main/java/com/appsmith/external/models/AuthenticationResponse.java

sumitsum suggested changes Mar 13, 2023

View reviewed changes

“sneha122” added 2 commits March 13, 2023 20:20

fix: code review comments

0822099

fix: code review fixes

fbede66

Merge branch 'release' into fix/gs-project-id

0e0c1e9

Irongade previously approved these changes Mar 20, 2023

View reviewed changes

fix: handled null case for project id

586d29e

sneha122 dismissed Irongade’s stale review via 586d29e March 20, 2023 08:32

fix: test if projectID is lost

a747da4

fix: revert test if project ID is lost

858fb9e

sumitsum approved these changes Mar 21, 2023

View reviewed changes

prapullac added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Mar 21, 2023

sneha122 merged commit 86cbda5 into release Mar 21, 2023

sneha122 deleted the fix/gs-project-id branch March 21, 2023 07:23

sneha122 mentioned this pull request Mar 23, 2023

[Bug]: Gsheet : Even after selecting the sheet all the sheet are visible to the user #21040

Closed

1 task

Conversation

sneha122 commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Uh oh!

sneha122 commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

sneha122 commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

sneha122 commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

sneha122 commented Mar 13, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sneha122 commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

sumitsum commented Mar 14, 2023

Uh oh!

sneha122 commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

sneha122 commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

sneha122 commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

sneha122 commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

sneha122 commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

sneha122 commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

sneha122 commented Mar 21, 2023

Uh oh!

github-actions bot commented Mar 21, 2023

Uh oh!

github-actions bot commented Mar 21, 2023

sneha122 commented Mar 13, 2023 •

edited

Loading