Skip to content

fix: Open explorer section on entity creation#21789

Merged
hetunandu merged 1 commit intoreleasefrom
fix/entity-explorer-collapse-state
Mar 30, 2023
Merged

fix: Open explorer section on entity creation#21789
hetunandu merged 1 commit intoreleasefrom
fix/entity-explorer-collapse-state

Conversation

@hetunandu
Copy link
Copy Markdown
Member

@hetunandu hetunandu commented Mar 27, 2023 •
edited
Loading

Description

The explorer remains collapsed even after creating an entity. This hides it from the user behind the collapsible. This change will ensure that the correct section opens up if it is closed so that the newly created entity is shown.

Opens collapsed section in the entity explorer when an entity is created

Fixes #11937

Media

Screen.Recording.2023-03-28.at.9.26.58.AM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@github-actions github-actions bot added the Bug Something isn't working label Mar 27, 2023
@hetunandu
Copy link
Copy Markdown
Member Author

hetunandu commented Mar 27, 2023

/ok-to-test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4531991128.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21789.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21789&runId=4531991128_1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2023

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_ContextMenu_spec.js

@hetunandu hetunandu requested a review from rahulramesha March 28, 2023 03:58
@github-actions github-actions bot added Entity Explorer Issues related to navigation using the entity explorer Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE labels Mar 28, 2023
@hetunandu
Copy link
Copy Markdown
Member Author

hetunandu commented Mar 28, 2023

/ok-to-test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4541107634.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 21789.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21789&runId=4541107634_1

@hetunandu
Copy link
Copy Markdown
Member Author

hetunandu commented Mar 29, 2023

/build-deploy-preview

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4550453176.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 21789.

@hetunandu
Copy link
Copy Markdown
Member Author

hetunandu commented Mar 29, 2023

/build-deploy-preview env=release

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4550458291.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21789.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2023

Deploy-Preview-URL: https://appsmith-kwmaxxeg6-get-appsmith.vercel.app

@hetunandu hetunandu merged commit f1e6ad6 into release Mar 30, 2023
@hetunandu hetunandu deleted the fix/entity-explorer-collapse-state branch March 30, 2023 07:21
@hetunandu hetunandu mentioned this pull request Mar 31, 2023
Merged
13 tasks
hetunandu added a commit that referenced this pull request Mar 31, 2023
@hetunandu
fix: Entity Explorer test case (#21939)
bb23521 
## Description

Fix test case failing because of changes in
#21789
It caused failures in tests that had a move of action involved.
This change will update the test cases to open the entity collapsible
section after a move of action

> Fix failing test case


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rahulramesha rahulramesha rahulramesha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer IDE Pod Issues that new developers face while exploring the IDE Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]-[1500]:Upon adding a new JSObj/Query/Blank API's - EntityExplorer should show the new item in the expanded tree

2 participants

@hetunandu @rahulramesha