Skip to content

fix: Changed SMTP placeholder for SMTP plugin (#21458)#21941

Merged
mohanarpit merged 1 commit intoreleasefrom
fix/21458-smtp-attachment-placeholder
Mar 31, 2023
Merged

fix: Changed SMTP placeholder for SMTP plugin (#21458)#21941
mohanarpit merged 1 commit intoreleasefrom
fix/21458-smtp-attachment-placeholder

Conversation

@sanveer-osahan
Copy link
Contributor

@sanveer-osahan sanveer-osahan commented Mar 31, 2023

Description

Fixed the attachment placeholder for a query created on SMTP datasource

Fixes #21458

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

For sending email with attachments, tested {{FilePicker.files}} and {{[FilePicker.files[0]]}}, both works successfully but {{FilePicker.files[0]}}

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@sanveer-osahan sanveer-osahan added Backend This marks the issue or pull request to reference server code Query & JS Pod Issues related to the query & JS Pod SMTP plugin Issues related to SMTP plugin Integrations Product Issues related to a specific integration labels Mar 31, 2023
@sanveer-osahan sanveer-osahan requested a review from sumitsum March 31, 2023 04:39
@github-actions github-actions bot added Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Up for grabs Issues that have little to no dependencies on design/product, can be picked up in an ad-hoc manner labels Mar 31, 2023
@sanveer-osahan
Copy link
Contributor Author

/ok-to-test sha=dc36c6cee7b7fab86ee5e330143d0a6f574803eb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4571645308.
Workflow: Appsmith External Integration Test Workflow.
Commit: dc36c6cee7b7fab86ee5e330143d0a6f574803eb.
PR: 21941.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=21941&runId=4571645308_1

@mohanarpit mohanarpit merged commit b053686 into release Mar 31, 2023
@mohanarpit mohanarpit deleted the fix/21458-smtp-attachment-placeholder branch March 31, 2023 05:39
@github-actions
Copy link

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js

  2. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_ContextMenu_spec.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend This marks the issue or pull request to reference server code Bug Something isn't working Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Query & JS Pod Issues related to the query & JS Pod SMTP plugin Issues related to SMTP plugin Up for grabs Issues that have little to no dependencies on design/product, can be picked up in an ad-hoc manner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SMTP: The hint text should be modified in the attachment section of the query.

3 participants