Skip to content

fix: Git connected apps are showing a status error#22046

Merged
hetunandu merged 1 commit intoreleasefrom
fix/status-api-index
Apr 4, 2023
Merged

fix: Git connected apps are showing a status error#22046
hetunandu merged 1 commit intoreleasefrom
fix/status-api-index

Conversation

@AnaghHegde
Copy link
Contributor

Description

Fix string index out of bound during the git status API

Fixes #22025

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@AnaghHegde AnaghHegde self-assigned this Apr 3, 2023
@AnaghHegde AnaghHegde requested a review from nayan-rafiq April 3, 2023 14:18
@github-actions github-actions bot added Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Release Blocker This issue must be resolved before the release labels Apr 3, 2023
@AnaghHegde
Copy link
Contributor Author

/ok-to-test sha=3c38c31

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4597793139.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3c38c31.
PR: 22046.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22046&runId=4597793139_1

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Widgets_Copy_Paste_Delete_Undo_Keyboard_Event_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/CategroySlider_spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
Identified Flaky tests

@hetunandu hetunandu merged commit 641ca39 into release Apr 4, 2023
@hetunandu hetunandu deleted the fix/status-api-index branch April 4, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Blocker This issue must be resolved before the release Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Git connected apps are showing a status error

3 participants