fix: Tab title text cut issue by priyanka-mahour · Pull Request #22486 · appsmithorg/appsmith

priyanka-mahour · 2023-04-17T12:05:17Z

Description

Fixed this issue: #21606 (comment)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Create a tabs widget
Add a tab
Add another tab titled "Send to Shipping"
'g' in the tab title shouldn't be cutting

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

welcome · 2023-04-17T12:05:20Z

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

somangshu · 2023-04-18T05:08:14Z

/build-deploy-preview env=release

somangshu · 2023-04-18T05:08:34Z

/ok-to-test sha=a48a13e

github-actions · 2023-04-18T05:08:43Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4728797637.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 22486.
recreate: .

github-actions · 2023-04-18T05:08:57Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4728800015.
Workflow: Appsmith External Integration Test Workflow.
Commit: a48a13e.
PR: 22486.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22486&runId=4728800015_1

somangshu · 2023-04-18T05:09:05Z

@priyanka-mahour please update you PR description properly!

priyanka-mahour · 2023-04-18T06:16:47Z

@priyanka-mahour please update you PR description properly!

@somangshu updated PR description, let me know if I need to do anything else
I checked for adding labels, looks like I don't have access to add labels

github-actions · 2023-04-18T06:40:10Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4728800015.
Commit: a48a13e.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/MobileResponsiveTests/HugWidgetValidationSpec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONFrom_Modal_spec.js

To know the list of identified flaky tests - Refer here

somangshu · 2023-04-18T09:37:07Z

/build-deploy-preview env=release

github-actions · 2023-04-18T09:37:29Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4730844020.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 22486.
recreate: .

github-actions · 2023-04-18T09:56:56Z

Deploy-Preview-URL: https://appsmith-j8i7pihii-get-appsmith.vercel.app

somangshu · 2023-04-19T05:59:05Z

After checking the DP, looks like the bug is fixed

somangshu · 2023-04-19T05:59:20Z

cc @chandannkumar @dilippitchika please verify once

chandannkumar · 2023-04-19T06:43:08Z

Tested this PR and LGTM

Tab title text cut issue is fixed
Tested on all canvas size

somangshu · 2023-04-19T07:11:52Z

@prsidhu @marks0351 HugWidgetValidationSpec.js is failing here, Can you folks please check and give us a signoff, this is a UI change, hence I am concerned.

github-actions · 2023-04-19T10:27:11Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4728800015.
Commit: a48a13e.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/MobileResponsiveTests/HugWidgetValidationSpec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONFrom_Modal_spec.js

To know the list of identified flaky tests - Refer here

marks0351 · 2023-04-19T10:32:16Z

@priyanka-mahour could you pull the latest release so that we can run the tests again on the branch.

priyanka-mahour · 2023-04-19T13:32:17Z

@priyanka-mahour could you pull the latest release so that we can run the tests again on the branch.

I have merged the latest release into my branch @marks0351
Please let me know if I need to do anything else

marks0351 · 2023-04-19T13:49:48Z

/ok-to-test

github-actions · 2023-04-19T13:50:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4744109531.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22486.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22486&runId=4744109531_1

github-actions · 2023-04-19T15:29:41Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4744109531.
Commit: ``.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js

To know the list of identified flaky tests - Refer here

fix: Tab titles cut text issue

f39bb4c

Merge branch 'appsmithorg:release' into fix/tabTitleCut

a48a13e

priyanka-mahour changed the title ~~Fix: Tab titles cut text issue~~ fix: Tab title text cut issue Apr 17, 2023

somangshu requested a review from jsartisan April 18, 2023 05:06

somangshu added Tab Widget Widgets Product This label groups issues related to widgets skip-testPlan labels Apr 18, 2023

jsartisan approved these changes Apr 19, 2023

View reviewed changes

priyankamahour added 2 commits April 19, 2023 18:56

Merge remote-tracking branch 'upstream/release' into fix/tabTitleCut

24da2a8

merge release

047e517

somangshu merged commit 8a04901 into appsmithorg:release Apr 20, 2023

somangshu linked an issue Apr 20, 2023 that may be closed by this pull request

[Bug]-[400]:Tab titles cut into text #21606

Closed

1 task

Conversation

priyanka-mahour commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Test Plan

Checklist:

Dev activity

QA activity:

Uh oh!

welcome bot commented Apr 17, 2023

Uh oh!

somangshu commented Apr 18, 2023

Uh oh!

somangshu commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

somangshu commented Apr 18, 2023

Uh oh!

priyanka-mahour commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

somangshu commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

somangshu commented Apr 19, 2023

Uh oh!

somangshu commented Apr 19, 2023

Uh oh!

chandannkumar commented Apr 19, 2023

Uh oh!

somangshu commented Apr 19, 2023

Uh oh!

github-actions bot commented Apr 19, 2023

Uh oh!

marks0351 commented Apr 19, 2023

Uh oh!

priyanka-mahour commented Apr 19, 2023

Uh oh!

marks0351 commented Apr 19, 2023

Uh oh!

github-actions bot commented Apr 19, 2023

Uh oh!

github-actions bot commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

priyanka-mahour commented Apr 17, 2023 •

edited

Loading