Skip to content

feat: To store user's Intercom email share consent on backend#22648

Merged
vishnu-gp merged 2 commits intoreleasefrom
feat/storing-intercom-consent-on-backend
Apr 24, 2023
Merged

feat: To store user's Intercom email share consent on backend#22648
vishnu-gp merged 2 commits intoreleasefrom
feat/storing-intercom-consent-on-backend

Conversation

@vishnu-gp
Copy link
Contributor

Description

Currently, there is no way for us to know any details about a user when they reach out to support via Intercom. Thus, we are not able to offer the right level of support to them basis their current plan.

The idea is to ask for consent to share user details with Appsmith before Intercom is enabled for a user, the basis which support can determine the right level of support.

This PR helps to store and retrieve the flag variable for a particular user which says whether the consent was given or not.

Fixes #22611

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • JUnit

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vishnu-gp vishnu-gp self-assigned this Apr 24, 2023
@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers CE Instance Usage For all issues relating to usage, licensing or billing on the CE instance Task A simple Todo Enhancement New feature or request labels Apr 24, 2023
@vishnu-gp vishnu-gp added Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Apr 24, 2023
@vishnu-gp
Copy link
Contributor Author

/ok-to-test sha=dec3b7c657dcb3d1780a42d9eb448c603971c88c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4782166523.
Workflow: Appsmith External Integration Test Workflow.
Commit: dec3b7c657dcb3d1780a42d9eb448c603971c88c.
PR: 22648.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22648&runId=4782166523_1

@vishnu-gp
Copy link
Contributor Author

/ok-to-test sha=2be01cd33f8c5495f903a48d62605425b4028488

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4782369371.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2be01cd33f8c5495f903a48d62605425b4028488.
PR: 22648.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22648&runId=4782369371_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4782369371.
Commit: 2be01cd33f8c5495f903a48d62605425b4028488.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Modal_background_spec.ts

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4782369371.
Commit: 2be01cd33f8c5495f903a48d62605425b4028488.
All cypress tests have passed 🎉

1 similar comment
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4782369371.
Commit: 2be01cd33f8c5495f903a48d62605425b4028488.
All cypress tests have passed 🎉

@vishnu-gp vishnu-gp merged commit e651f62 into release Apr 24, 2023
@vishnu-gp vishnu-gp deleted the feat/storing-intercom-consent-on-backend branch April 24, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers CE Instance Usage For all issues relating to usage, licensing or billing on the CE instance Enhancement New feature or request Task A simple Todo Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add BE flag variable for user's intercom consent

2 participants