Skip to content

fix: display name validation (client)#22938

Merged
eco-monk merged 7 commits intoreleasefrom
fix/display-name-validation
May 4, 2023
Merged

fix: display name validation (client)#22938
eco-monk merged 7 commits intoreleasefrom
fix/display-name-validation

Conversation

@eco-monk
Copy link
Contributor

@eco-monk eco-monk commented May 3, 2023 •
edited
Loading

Description

Added client validation for display name field.

  • Allows all language characters, ., -, ' and space.
    (Every other special character will throw an error e.g. html content)
  • Save field when pressing enter / on blur.

Fixes #22578

Media
https://www.loom.com/share/ad96ed687c0740379326462ffc05a0ec

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@github-actions github-actions bot added Bug Something isn't working IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE labels May 3, 2023
@eco-monk
Copy link
Contributor Author

eco-monk commented May 3, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented May 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4868765507.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22938.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22938&runId=4868765507_1

@eco-monk
Copy link
Contributor Author

eco-monk commented May 3, 2023

/build-deploy-preview env=release

@github-actions
Copy link

github-actions bot commented May 3, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4868768614.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 22938.
recreate: .

@github-actions
Copy link

github-actions bot commented May 3, 2023

Deploy-Preview-URL: https://appsmith-qjs66sv5y-get-appsmith.vercel.app

@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868765507.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AllWidgets_Reset_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/freeze_column_query_change_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  11. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  14. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  15. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  16. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  17. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868765507.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/freeze_column_query_change_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  14. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  15. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  16. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

1 similar comment
@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868765507.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/freeze_column_query_change_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  14. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  15. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  16. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

hetunandu
hetunandu previously approved these changes May 3, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4868765507.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22938.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22938&runId=4868765507_4

@eco-monk
Copy link
Contributor Author

eco-monk commented May 3, 2023

/ok-to-test

@eco-monk
Copy link
Contributor Author

eco-monk commented May 3, 2023

/build-deploy-preview env=release

@github-actions
Copy link

github-actions bot commented May 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4871223771.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22938.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22938&runId=4871223771_1

@github-actions
Copy link

github-actions bot commented May 3, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4871226599.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 22938.
recreate: .

@appsmithorg appsmithorg deleted a comment from github-actions bot May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Deploy-Preview-URL: https://appsmith-23mx5cr0m-get-appsmith.vercel.app

@eco-monk eco-monk requested a review from hetunandu May 3, 2023 12:23
@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4871223771.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  9. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  14. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

akash-codemonk
akash-codemonk previously approved these changes May 3, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4871223771.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  9. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  14. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

1 similar comment
@github-actions
Copy link

github-actions bot commented May 3, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4871223771.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts

  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  9. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  11. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  13. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  14. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions github-actions bot added the QA Needs QA attention label May 4, 2023
@eco-monk eco-monk enabled auto-merge (squash) May 4, 2023 08:25
@github-actions
Copy link

github-actions bot commented May 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4878543677.
Commit: ``.
All cypress tests have passed 🎉

@NilanshBansal
Copy link
Contributor

NilanshBansal commented May 4, 2023

/ci-merge-check

@github-actions
Copy link

github-actions bot commented May 4, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/4880942182
PR: 22938

@github-actions
Copy link

github-actions bot commented May 4, 2023

Hurray!🎉 Proceeding to Merge!!!

@github-actions
Copy link

github-actions bot commented May 4, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/4880942182
PR: 22938

@github-actions
Copy link

github-actions bot commented May 4, 2023

Hurray!🎉 Proceeding to Merge!!!

@eco-monk
Copy link
Contributor Author

eco-monk commented May 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented May 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4881272220.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22938.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22938&runId=4881272220_1

mohanarpit
mohanarpit reviewed May 4, 2023
View reviewed changes
mohanarpit
mohanarpit reviewed May 4, 2023
View reviewed changes
@eco-monk eco-monk requested a review from mohanarpit May 4, 2023 10:19
@eco-monk
Copy link
Contributor Author

eco-monk commented May 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented May 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4881666196.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22938.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22938&runId=4881666196_1

@github-actions
Copy link

github-actions bot commented May 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881272220.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented May 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881666196.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented May 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881272220.
Commit: ``.
All cypress tests have passed 🎉

@github-actions
Copy link

github-actions bot commented May 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881666196.
Commit: ``.
All cypress tests have passed 🎉

@eco-monk eco-monk merged commit 6e39a3a into release May 4, 2023
@eco-monk eco-monk deleted the fix/display-name-validation branch May 4, 2023 12:59
somangshu pushed a commit that referenced this pull request May 10, 2023
@eco-monk @somangshu
fix: display name validation (client) (#22938)
60bcb15 
(cherry picked from commit 6e39a3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanarpit mohanarpit mohanarpit approved these changes

@hetunandu hetunandu Awaiting requested review from hetunandu

@akash-codemonk akash-codemonk Awaiting requested review from akash-codemonk

@NilanshBansal NilanshBansal Awaiting requested review from NilanshBansal

Assignees

No one assigned

Labels

Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Input field validation is missing for display name

6 participants

@eco-monk @Richarex @NilanshBansal @mohanarpit @hetunandu @akash-codemonk