feat: peek overlay nested properties + perf improvements by eco-monk · Pull Request #23414 · appsmithorg/appsmith

eco-monk · 2023-05-16T15:00:25Z

Fixes #23057
Fixes #23054

Description

TL;DR Added support for peeking on nested properties. e.g. Api1.data[0].id.

This won't work when:

local variables are involved in the expression.
e.g. Api1.data[x].id won't support peeking at the variable [x] or anything after that.
library code is involved e.g. moment, _ etc...
when functions are called. e.g. Api1.data[0].id.toFixed()

Because these cases requires evaluation.

Media (old vs new)

https://www.loom.com/share/dedcf113439c4ee2a19028acca54045e

Performance improvements:

Use AST to identify expressions instead marking text manually.
This reduces the number of markers we process (~ half).
Before
After
AST logs
https://www.loom.com/share/ddde93233cc8470ea04309d8a8332240

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

Manual
Jest
Cypress

Test Plan

https://github.com/appsmithorg/TestSmith/issues/2402

Issues raised during DP testing

#23414 (comment)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

eco-monk · 2023-05-16T15:00:58Z

/ok-to-test

github-actions · 2023-05-16T15:01:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4993520084.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=4993520084_1

eco-monk · 2023-05-16T15:32:52Z

/ok-to-test

github-actions · 2023-05-16T15:33:16Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4993872765.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=4993872765_1

eco-monk · 2023-05-16T23:58:36Z

/ok-to-test

github-actions · 2023-05-16T23:58:58Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4997774286.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=4997774286_1

github-actions · 2023-05-17T01:31:53Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4997774286.
Commit: ``.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/PeekOverlay/PeekOverlay_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-05-17T02:19:07Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4997774286.
Commit: ``.
The following are new failures, please fix them before merging the PR:

cypress/integration/Regression_TestSuite/ClientSideTests/PeekOverlay/PeekOverlay_Spec.ts

To know the list of identified flaky tests - Refer here

eco-monk · 2023-05-24T05:19:51Z

/build-deploy-preview env=release skip-tests=true

github-actions · 2023-05-24T05:19:58Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5064992106.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=5064992106_1

github-actions · 2023-05-24T05:20:15Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5064994508.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 23414.
recreate: .

github-actions · 2023-05-24T05:46:31Z

Deploy-Preview-URL: https://appsmith-mton5vimp-get-appsmith.vercel.app

github-actions · 2023-05-24T06:35:27Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5064992106.
Commit: ``.
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-05-24T07:08:11Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5064992106.
Commit: ``.
All cypress tests have passed 🎉

eco-monk · 2023-05-24T11:56:44Z

/ok-to-test

github-actions · 2023-05-24T11:57:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5068323702.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=5068323702_1

eco-monk · 2023-05-24T12:00:51Z

/build-deploy-preview

github-actions · 2023-05-24T12:01:15Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5068359549.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 23414.
recreate: .

github-actions · 2023-05-24T12:34:02Z

Deploy-Preview-URL: https://ce-23414.dp.appsmith.com

github-actions · 2023-05-24T13:20:35Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5068323702.
Commit: ``.
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/e2e/Sanity/Datasources/Airtable_Basic_Spec.ts

To know the list of identified flaky tests - Refer here

eco-monk · 2023-05-25T06:35:51Z

/build-deploy-preview env=release skip-tests=true

github-actions · 2023-05-25T06:36:14Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5076863594.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 23414.
recreate: .

github-actions · 2023-05-25T07:01:33Z

Deploy-Preview-URL: https://appsmith-iahkncx92-get-appsmith.vercel.app

ramsaptami · 2023-05-25T10:28:31Z

LGTM
cc: @eco-monk

eco-monk · 2023-05-26T05:25:05Z

/ok-to-test

github-actions · 2023-05-26T05:25:31Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5087533415.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23414.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23414&runId=5087533415_1

github-actions · 2023-05-26T06:32:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5087533415.
Commit: ``.
All cypress tests have passed 🎉

eco-monk added 12 commits April 25, 2023 11:06

highlight init

23fc7f8

types

c41f48b

hover and ast

d193b94

Merge branch 'release' into feat/peek-overlay-phase-2

d93460f

peek overlay with this keyword

7ee8069

tests for this keyword

e701efd

comment

00cbc7d

filter eval data

962425f

filter call expression

411d639

filter local variable accessors

157a545

reset style

663eaba

Merge branch 'release' into feat/peek-overlay-phase-2

05a801a

eco-monk added 2 commits May 16, 2023 21:00

basic clean up

caeac2e

handle error in promsie

9c3c276

eco-monk added 3 commits May 16, 2023 21:43

Merge branch 'release' into feat/peek-overlay-phase-2

917c3fa

error handling

af7997d

Merge branch 'release' into feat/peek-overlay-phase-2

3723b27

eco-monk added 4 commits May 17, 2023 06:05

log perf

0626036

Merge branch 'release' into feat/peek-overlay-phase-2

bd1c65c

log update

6ef7024

Merge branch 'release' into feat/peek-overlay-phase-2

382666f

split nav data and peek data

62fcc51

comment

9c59b55

eco-monk added 4 commits May 24, 2023 15:47

filter libraries

51d07f5

filter global functions and consecutive function calls

5a67cf3

clean up

23e80cb

clean up tests

b6e69bb

ramsaptami added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label May 25, 2023

eco-monk requested a review from hetunandu May 26, 2023 10:03

hetunandu approved these changes May 26, 2023

View reviewed changes

eco-monk merged commit 9dd015a into release May 26, 2023

eco-monk deleted the feat/peek-overlay-phase-2 branch May 26, 2023 11:42

Conversation

eco-monk commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Media (old vs new)

Performance improvements:

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Uh oh!

eco-monk commented May 16, 2023

Uh oh!

github-actions bot commented May 16, 2023

Uh oh!

eco-monk commented May 16, 2023

Uh oh!

github-actions bot commented May 16, 2023

Uh oh!

eco-monk commented May 16, 2023

Uh oh!

github-actions bot commented May 16, 2023

Uh oh!

github-actions bot commented May 17, 2023

Uh oh!

github-actions bot commented May 17, 2023

Uh oh!

eco-monk commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

eco-monk commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

eco-monk commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

github-actions bot commented May 24, 2023

Uh oh!

eco-monk commented May 25, 2023

Uh oh!

github-actions bot commented May 25, 2023

Uh oh!

github-actions bot commented May 25, 2023

Uh oh!

ramsaptami commented May 25, 2023

Uh oh!

eco-monk commented May 26, 2023

Uh oh!

github-actions bot commented May 26, 2023

Uh oh!

github-actions bot commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eco-monk commented May 16, 2023 •

edited

Loading