fix: Autocomplete trigger changes by arunvjn · Pull Request #24025 · appsmithorg/appsmith

arunvjn · 2023-06-05T08:29:42Z

Description

PR to fix autocomplete trigger

Disables autocomplete trigger when ctrl/meta/alt is pressed except for (ctrl/meta)+space.
Disable autocomplete inside strings and comments

PR fixes following issue(s)

Fixes #15429

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Manual
Jest
Cypress

Test Plan

Keyboard shortcut check for autocomplete
Copy paste action-based check
autocomplete suggestions inside strings and comments

Issues raised during DP testing

#24025 (comment)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

- Disables autocomplete trigger when ctr/meta is pressed - Disable autocomplete inside strings and comments

arunvjn · 2023-06-05T12:06:39Z

/ok-to-test sha=3358bfe

github-actions · 2023-06-05T12:07:04Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5176899410.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3358bfe.
PR: 24025.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24025&runId=5176899410_1

arunvjn · 2023-06-05T12:07:36Z

/build-deploy-preview env=release

github-actions · 2023-06-05T12:07:56Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5176909136.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 24025.
recreate: .

github-actions · 2023-06-05T12:38:28Z

Deploy-Preview-URL: https://appsmith-lm8bye8co-get-appsmith.vercel.app

ohansFavour

Looks good

github-actions · 2023-06-05T13:16:27Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5176899410.
Commit: 3358bfe.
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
cypress/e2e/Sanity/Datasources/AuthenticatedApiWithOAuth_spec.ts

To know the list of identified flaky tests - Refer here

ramsaptami · 2023-06-05T15:56:50Z

Prettify using keyboard shortcut still brings up autocomplete at cursor position

github-actions · 2023-06-05T16:15:38Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5176899410.
Commit: 3358bfe.
All cypress tests have passed 🎉

arunvjn · 2023-06-06T04:30:22Z

/ok-to-test sha=5b553f0

github-actions · 2023-06-06T04:30:46Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5184611285.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5b553f0.
PR: 24025.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24025&runId=5184611285_1

arunvjn · 2023-06-06T04:30:57Z

/build-deploy-preview env=release

github-actions · 2023-06-06T04:31:21Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5184614831.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 24025.
recreate: .

github-actions · 2023-06-06T05:04:47Z

Deploy-Preview-URL: https://appsmith-67vbxwdxv-get-appsmith.vercel.app

arunvjn · 2023-06-06T05:16:03Z

Prettify using keyboard shortcut still brings up autocomplete at cursor position

Windows use shift+alt+f to prettify and wasn't handled earlier. You can now verify the fix at https://appsmith-67vbxwdxv-get-appsmith.vercel.app/

github-actions · 2023-06-06T05:38:04Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5184611285.
Commit: 5b553f0.
All cypress tests have passed 🎉

ramsaptami · 2023-06-06T05:42:22Z

LGTM @arunvjn

Aishwarya-U-R

Otherwise cypress looks good.

Aishwarya-U-R · 2023-06-06T08:44:17Z

    });
  });
+
+  it.only("10. Bug #10115 Autocomplete needs to show async await keywords instead of showing 'no suggestions'", () => {


Remove .only. Move case to different spec.

arunvjn · 2023-06-06T08:48:15Z

/ok-to-test sha=6cd2bc3

github-actions · 2023-06-06T08:48:39Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5186523300.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6cd2bc3.
PR: 24025.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24025&runId=5186523300_1

Autocomplete trigger changes

a4646a5

- Disables autocomplete trigger when ctr/meta is pressed - Disable autocomplete inside strings and comments

github-actions bot added Autocomplete Issues related to the autocomplete Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Medium Issues that frustrate users due to poor UX labels Jun 5, 2023

github-actions bot requested review from albinAppsmith and tanvibhakta June 5, 2023 08:30

Added Cypress tests

3358bfe

arunvjn added the Add/Update Test Plan label Jun 5, 2023

arunvjn requested review from ohansFavour and rishabhrathod01 and removed request for albinAppsmith, rishabhrathod01 and tanvibhakta June 5, 2023 10:07

github-actions bot requested review from albinAppsmith and tanvibhakta June 5, 2023 12:09

ohansFavour previously approved these changes Jun 5, 2023

View reviewed changes

ramsaptami removed the Add/Update Test Plan label Jun 5, 2023

Disable autocomplete on prettify for windows machine

5b553f0

arunvjn dismissed ohansFavour’s stale review via 5b553f0 June 6, 2023 04:25

arunvjn requested a review from ohansFavour June 6, 2023 04:30

ramsaptami added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jun 6, 2023

ohansFavour previously approved these changes Jun 6, 2023

View reviewed changes

Aishwarya-U-R reviewed Jun 6, 2023

View reviewed changes

arunvjn added 2 commits June 6, 2023 14:16

Remove accidental 'only'

a96e7df

Changed test name

6cd2bc3

arunvjn dismissed ohansFavour’s stale review via 6cd2bc3 June 6, 2023 08:47

Aishwarya-U-R approved these changes Jun 6, 2023

View reviewed changes

Aishwarya-U-R merged commit e8243ad into release Jun 6, 2023

Aishwarya-U-R deleted the fix/15429-fix-random-autocomplete branch June 6, 2023 08:52

Conversation

arunvjn commented Jun 5, 2023 • edited by ramsaptami Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR fixes following issue(s)

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Uh oh!

arunvjn commented Jun 5, 2023

Uh oh!

github-actions bot commented Jun 5, 2023

Uh oh!

arunvjn commented Jun 5, 2023

Uh oh!

github-actions bot commented Jun 5, 2023

Uh oh!

github-actions bot commented Jun 5, 2023

Uh oh!

ohansFavour left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 5, 2023

Uh oh!

ramsaptami commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2023

Uh oh!

arunvjn commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

arunvjn commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

arunvjn commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

ramsaptami commented Jun 6, 2023

Uh oh!

Aishwarya-U-R left a comment

Choose a reason for hiding this comment

Uh oh!

Aishwarya-U-R Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

arunvjn commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arunvjn commented Jun 5, 2023 •

edited by ramsaptami

Loading

ramsaptami commented Jun 5, 2023 •

edited

Loading