fix: use newer editableText component

[tanvibhakta]

Description

1. Removes red background on error (fixes [Task]: Editable input error state not proper #24098)
2. Changes saving state icon to use new standard loader icon (fixes [Bug]: Old loader while editing widget names in Property pane #24112)

Media

Screen.Recording.2023-06-12.at.10.02.02.AM.mov

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

• Manual
• Jest
• Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• PR is being merged under a feature flag

QA activity:

• Speedbreak features have been covered
• Test plan covers all impacted features and areas of interest
• Test plan has been peer reviewed by project stakeholders and other QA members
• Manually tested functionality on DP
• We had an implementation alignment call with stakeholders post QA Round 2
• Cypress test cases have been added and approved by SDET/manual QA
• Added Test Plan Approved label after Cypress tests were reviewed
• Added Test Plan Approved label after JUnit tests were reviewed

[tanvibhakta]

/ok-to-test
/build-deploy-preview env=release skip-tests=true

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5239569417.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24342.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24342&runId=5239569417_1

[tanvibhakta]

/build-deploy-preview env=release skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5239576264.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 24342.
recreate: .

[github-actions]

Deploy-Preview-URL: https://appsmith-6vcmujpcn-get-appsmith.vercel.app

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5239569417.
Commit: ``.
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategroySlider_spec.ts

To know the list of identified flaky tests - Refer here

[shadabbuchh]

• Issue 1 - Fixed

• Issue 2 - We are now able to see the new Loader. However the loader does not seem to rotate like it does in other places. Also we are not able to see the loader after changing the Workspace name.

Screen.Recording.2023-06-12.at.11.20.11.AM.mov

[tanvibhakta]

However the loader does not seem to rotate like it does in other places.

To do so we would have to update the design-system-old spinner, which is not useful as we are building a new component for this in a few weeks time. I have changed the icon so that the difference is not glaring when seen for a split second.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5239569417.
Commit: ``.
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategroySlider_spec.ts

To know the list of identified flaky tests - Refer here

[tanvibhakta]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5240988424.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24342.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24342&runId=5240988424_1

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5240988424.
Commit: ``.
All cypress tests have passed 🎉

[tanvibhakta]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5254642269.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24342.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24342&runId=5254642269_1

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5254642269.
Commit: ``.
All cypress tests have passed 🎉

[albinAppsmith]

@tanvibhakta I see we are using old gray in edit field. Approving the rest of the changes.