Skip to content

Comments

chore: Adding Redis metrics and dashboard to observability stack#24755

Merged
nidhi-nair merged 2 commits intoreleasefrom
fix/adding-redis-metrics
Jun 27, 2023
Merged

chore: Adding Redis metrics and dashboard to observability stack#24755
nidhi-nair merged 2 commits intoreleasefrom
fix/adding-redis-metrics

Conversation

@nidhi-nair
Copy link
Contributor

Description

Starts to send Redis operation spans via Zipkin and observation metrics via Prometheus. Adds Redis metrics to our observability stack as well.

PR fixes following issue(s)

Fixes #24024

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

@nidhi-nair nidhi-nair requested a review from sharat87 June 22, 2023 12:56
@github-actions github-actions bot added Enhancement New feature or request skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Enhancement New feature or request labels Jun 22, 2023
sharat87
sharat87 previously approved these changes Jun 27, 2023
Copy link
Member

@sharat87 sharat87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nidhi-nair nidhi-nair requested a review from sharat87 June 27, 2023 04:49
@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code Query & JS Pod Issues related to the query & JS Pod Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform DevOps Pod Issues related to devops Enhancement New feature or request Observability Issues related to observability on the Appsmith instance labels Jun 27, 2023
@nidhi-nair nidhi-nair merged commit 5e46a2f into release Jun 27, 2023
@nidhi-nair nidhi-nair deleted the fix/adding-redis-metrics branch June 27, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend This marks the issue or pull request to reference server code Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform DevOps Pod Issues related to devops Enhancement New feature or request Observability Issues related to observability on the Appsmith instance Query & JS Pod Issues related to the query & JS Pod skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Feature]: Expose metrics on time taken by Redis operations

2 participants